search

stanfordnmbl / opencap-api

Apache License 2.0
5 stars 7 forks source link

Changed valid sessions criteria and retrieving only required sessions. #15

Closed AlbertoCasasOrtiz closed 1 year ago

AlbertoCasasOrtiz commented 1 year ago

Fixes https://github.com/stanfordnmbl/opencap-viewer/issues/55.

I have changed the criteria of what a valid session is according to https://github.com/stanfordnmbl/opencap-viewer/issues/55.

Also, I detected we were querying all sessions from database, sorting them and then filtering; instead of directly querying only sessions complying with the filter, and then sorting. This PR also fixes it.

antoinefalisse commented 1 year ago

@AlbertoCasasOrtiz looks like there is a conflict? Might taking a look. We can test when merged in dev. Thanks.

AlbertoCasasOrtiz commented 1 year ago

@antoinefalisse The conflict should be solved now. I am going to merge.

AlbertoCasasOrtiz commented 1 year ago

On my side seems to work, but I only have 1 session. Can you check if it is working with more than one session, and check if the Load all button works (hopefully faster than before). @antoinefalisse @suhlrich

antoinefalisse commented 1 year ago

Thanks, I will test. I guess we need to wait for the "delete" feature to be ready before merging into main.