stanfordnmbl / opencap-api

Apache License 2.0
5 stars 7 forks source link

cannot download data from public session if not your session #79

Closed antoinefalisse closed 1 year ago

antoinefalisse commented 1 year ago

If you are not logged in, you cannot download data from a session, even if public. Not sure what we want there, do we want to allow or not? We should either remove the button (if we do not allow) or make possible (if we keep the button). Thoughts @suhlrich ?

suhlrich commented 1 year ago

I think we do want to be able to download data from public sessions if not logged in.

On Jun 3, 2023, at 5:25 AM, Antoine Falisse @.***> wrote:



If you are not logged in, you cannot download data from a session, even if public. Not sure what we want there, do we want to allow or not? Thoughts @suhlrichhttps://github.com/suhlrich ?

— Reply to this email directly, view it on GitHubhttps://github.com/stanfordnmbl/opencap-api/issues/79, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKOYGJ5RKMTEKNYLOPLYHSDXJMUJTANCNFSM6AAAAAAYZIJ2RI. You are receiving this because you were mentioned.Message ID: @.***>

antoinefalisse commented 1 year ago

@anastasiiadidan could we make possible downloading public sessions by anyone? Currently, you need to be logged in. Here is an example: https://dev.app.opencap.ai/session/00e58b94-c70c-4835-81a0-e45abc3efcfc

anastasiiadidan commented 1 year ago

@antoinefalisse sure, will work on it