search

stanfordnmbl / opencap-core

Main OpenCap processing pipeline
Apache License 2.0
151 stars 120 forks source link

Adding the 2024 iPad Air models to the intrinsics #195

Closed mattpetrucci closed 2 weeks ago

mattpetrucci commented 2 weeks ago

Per the mapping on this site: https://stackoverflow.com/questions/26028918/how-to-determine-the-current-iphone-device-model, I added folders for the iPad Air 11" and 13" models (which are iPad 14,9, iPad 14,10, and iPad 14,11; iPad 14,8 already existed).

@suhlrich and @antoinefalisse please confirm this is correct.

antoinefalisse commented 2 weeks ago

@mattpetrucci, thanks a lot!

A few questions:

  1. Is it the same set of extrinsics for both models? Or two different sets?
  2. iPad 14.8 does not exist in our database. I see iPhone 14.8 only.
  3. Did you use the big checkerboard of the lab for computing them?
  4. Did you chat with @suhlrich about our process for computing them (like making sure you cover the whole screen, at different angles, etc)?

We used to have a folder where we would save the calibrated images. Do you know where it is @suhlrich ?

mattpetrucci commented 2 weeks ago

@antoinefalisse Whoops, I mixed iPhone and iPad. This change is incorrect. It might be cleaner to start with a new branch and pull request. I will close this one.

To answer your questions, from what I can find the intrinsics for the iPad Air 2024 should be the same as iPad Air 2022.