stanfordnmbl / opencap-iphone

Apache License 2.0
0 stars 1 forks source link

Connected vs not-connected #12

Closed antoinefalisse closed 2 years ago

antoinefalisse commented 2 years ago

We should inform users when there is a connection issue. Let's proceed this way.

  1. When the device is connected to the server, we should have a green check mark somewhere on the screen. This could look like this: image. The device is connected when the http response status is everything but 404 (usually 200 I think). See this example: image

  2. When the device is disconnected from the server, we should have a red cross somewhere on the screen. This could look like this: image. The device is disconnected when the http response status is 404. See this example: image

@xhardcorex do you think it is feasible to implement something like this? @suhlrich and @kidzik feel free to jump in if you have other thoughts.

xhardcorex commented 2 years ago

@antoinefalisse Yes, I can implement it. What do you thing about the following solution,if the app is connected, we don't show anything. If the app is disconected we present message popup with error until the application connects to the server image

antoinefalisse commented 2 years ago

Yeah, I like that! The error message could say "Device no longer connected to server, verify your internet connect"

xhardcorex commented 2 years ago

Available in Testflight - build 1.6 (6)

antoinefalisse commented 2 years ago

Looking great, just one remark. I made a typo above (connect instead of connection), could you replace the error message with:

"Device no longer connected to server, verify your internet connection".

Let me know when you have a new build. Thanks!

xhardcorex commented 2 years ago

I provided a new build to Testflight 1.6 (7) with a text fix. Let me know please if you have other tasks for me. Thanks!