search

stanfordnmbl / osim-rl

Reinforcement learning environments with musculoskeletal models
http://osim-rl.stanford.edu/
MIT License
896 stars 249 forks source link

confusion in script/example.py #99

Closed leejk526 closed 6 years ago

leejk526 commented 6 years ago

Hi, I've done in 'ver1.5.5'. I'm trying to run "scripts/example.py" code for training with command "python scripts/example.py --visualize --train --model sample"

But, the interpreter said, 2018-04-22 4 17 12

So, I wondered that where is "osim/env/*" path. When I tried that, 2018-04-22 4 18 45

osim path is in virtual python root library path, not the "$osim-rl/osim/env" path. I annotated "import opensim as osim" in the "scripts/example.py" file like this. 2018-04-22 4 24 43

Am I right? My primary question is a confusion of the real path 'osim/env'. why does the editor write "import opensim as osim"?

Thank you for reading.

kidzik commented 6 years ago

Yes you are right. opensim package is actual OpenSim simulator, while the reinforcement learning package is called osim. Therefore import opensim as osim is not only confusing but just wrong. It was there in the old script from the times we were starting to build this environment. Thanks for the catch!

The script is now here https://github.com/stanfordnmbl/osim-rl/blob/master/examples/ddpg.keras-rl.py

leejk526 commented 6 years ago

Thank you for response!