search

stanfordnqp / spins-b

Photonic optimization library
GNU General Public License v3.0
290 stars 114 forks source link

adds empty init files #65

Closed jonbenfri closed 2 years ago

jonbenfri commented 2 years ago

Summary: Python module is installed but does not import due to missing init file. Adding empty init file allows spins module to be imported.

Description: I was unable to import spins in Python after installation and tracked down the issue to a deleted init file. Adding an empty init file allows the spins Python module to be imported successfully. Possibly solves issues #33, #24, and #56.

Steps to reproduce:

  1. Git clone most recent master branch 9cd1510fef5abe650597fc8e66e9f6180e9a5aa4.
  2. Install using: pip install ./spins-b
  3. Open python interpreter
  4. Try to import spins: import spins
  5. Error message: ModuleNotFoundError: No module named 'spins'

Additional Note: An init file was initially created containing multiple module imports, and looks to have been deleted after those imports were moved to other python files. The init file was removed in 1e99cdf86d2c370ae6f117829fbe0295a0f934b4.

joamatab commented 2 years ago

Hi Jon

73 also includes these changes

I think we can close this PR