stanhebben / MineTweaker3

Tweak your minecraft experience
65 stars 32 forks source link

Changing name of liquid in liquid dictionary? #374

Open Guinaro opened 8 years ago

Guinaro commented 8 years ago

If possible I would like to be able to change the name of liquid registered in the liquid dictionary. (Not the id, but actual display name)

Example: Thermal Expansion has an ore named Mana Infused Ore. In the ore dictionary it is registered as oreMithril. Tinker's Constructs has a fluid for this created registered as liquid:mithril. But the name of the liquid registered as Molten Mana Infused Metal. I can use a game.setLocalization("en_US", "tile.fluid.molten.mithril.name", "Molten Mithril"); command in minetweaker. And in Nei it changes the name as you view it. However it doesn't get updated in the NEI viewing of casting mithril items. When hovering over the poring fluid it still shows Molten Mana Infused Metal.

Guinaro

PrincessRTFM commented 8 years ago

When you change the name of the liquid by the method you described, does WAILA's in-world display show the liquid with the new name or the old one?

LakMoore commented 8 years ago

I think Guinaro means WAILA, rather than NEI as written.

Guinaro commented 8 years ago

Well when placing the liquid in to the world with a Pressure Pipes Canister, Clay bucket or normal bucket with Waila it shows the fluid as molten mithril. That isn't the issue. It is actually when using NEI that the fluid still shows up as Molten Mana Infused Metal. Like in Openblocks Tanks, or when viewing the page of the casting tinker's construct items. And I think the only solution for this is actually going into the fluid registry and changing the name of the fluid itself. I guess I'm nitpicking here. But if you want to present a consistent interface for a modpack and it's items: having an identical fluid with two different names or a fluid which is registered as Fluid ABC casting items with names DEF metal is not really transparent to the user.

I forgot to mention this: but I am using the 1.7.10 Latest version.

LakMoore commented 8 years ago

I would agree, consistent would be best.

What about using the following in a Minetweaker script?

NEI.overrideName(liquid:mithril, "Molten Mithril");

Guinaro commented 8 years ago

Yes, or maybe a seperate versions for Liquids: NEI.overrideLiquidName(liquid:mithril, "Molten Mithril");

PrincessRTFM commented 8 years ago

That would probably depend on NEI, requiring a potential change to their API.

Guinaro commented 8 years ago

If possible I think a better option is implement something indepent of any other API's then.

PrincessRTFM commented 8 years ago

If it's possible to change the name in the fluid registry AND have the change propagate to things like fluid containers and NEI/WAILA, that'd be really neat. But (and I admit to having no knowledge on this particular subject) this would only really work if fluid containers dynamically construct their display name from the contained fluid. Like having "%s Bucket" instead of constructing static names like "Lava Bucket" and "Water Bucket" (for example).

LakMoore commented 8 years ago

I wasn't suggesting a new feature... NEI.overrideName is a function of Minetweaker that already exists. I was suggesting that you try it to see if it fixes your problem.

NEI.overrideName(liquid:mithril, "Molten Mithril");

Guinaro commented 8 years ago

No that didn't help. Anyhow I have been experimenting with the NEI.override functions, and when using it it is constantly spamming warning messages of Stuck names. So a different form of game.setLocalisation("en_US", "", ""); But specifically for fluids, or something like: ... var mithril = fluid:molten.mithril; mithril.changeName("Molten Mithril");

Blue64 commented 7 years ago

I usually try to avoid repeating a var/val on accident, such as mithril.changeName("Molten Mithril"); I would probably use mythril.changeName("Molten Mithril"); just to avoid potentially confusing the Compiler. Also I believe this has had a similar topic discussed (at quite long length) in the past involving Fluid Names with Spaces (<fluid:Life Essence> anyone?). I believe that it was a rather astute point made about the containers and Tanks, you might need to track down each one if you truly desire complete immersion and rename each and every Item & Entity. As for the Recipes, if I'm not mistaken, you should be able to interact with the Recipes via ModTweaker, and potentially re-create the Recipes to force the names to update

Remove Tinkers' Recipes
Change NEI Name
Create Tinkers' Recipes

this might cause Tinkers' & NEI to become quite a bit more cooperative.

jaredlll08 commented 7 years ago

The fluid name with spaces wouldn't be an issue here, from what I can tell he is trying to change the display name, which there is no code for currently.

@Blue64 are you on discord? if so, join my discord server, http://discord.blamejared.com/ I would like to talk to you about something, if not, where can I reach you?

Blue64 commented 7 years ago

I actually have never set up a Discord account ^_^; I'm usually reachable on here, I do also have a FaceBook & a YouTube. Probably FaceBook Messenger would be best (I don't usually actually get on FaceBook it's self, just normally use Messenger)