staniel359 / muffon

Advanced multi-source music streaming + discovery client for desktop. Free, clean, no login, no ads.
https://muffon.netlify.app
GNU Affero General Public License v3.0
1.18k stars 49 forks source link

Add preview on taskbar icon hover #136

Open sstvskids opened 6 months ago

sstvskids commented 6 months ago

Example: image

This would be useful to creators and help them out alot.

xyloflake commented 6 months ago

Hmm, interesting. @staniel359 @gamersi what do you think?

My 2 cents, this’ll not be that good. We can’t implement the play button or next or previous. Because, you are not supposed to play different tracks from different tabs simultaneously.

It’ll be just the preview of the tab if this is implemented, the preview will only show what you’d see once you open the tab.

xyloflake commented 6 months ago

Hey @staniel359 @gamersi you forgot about this.

gamersi commented 6 months ago

Yeah with the tabs it will get pretty messy

staniel359 commented 6 months ago

@sstvskids Hello. Thanks, added to planned.

@xyloflake @gamersi That's techically feasible: https://www.electronjs.org/docs/latest/tutorial/windows-taskbar#thumbnail-toolbars

Also keyboard player controls work now, you can check yourselves.

xyloflake commented 5 months ago

@staniel359 it's not about doable or not. It's about should you do it? IMHO it would make things messier.

staniel359 commented 5 months ago

@xyloflake Why? It'll look like a Windows media player.

gamersi commented 5 months ago

@xyloflake Why? It'll look like a Windows media player.

what if someone has multiple songs playing in different tabs?

xyloflake commented 5 months ago

@staniel359 sorry, I misunderstood this as implementing tab preview for muffon tabs, not windows tabs.

staniel359 commented 5 months ago

@gamersi

what if someone has multiple songs playing in different tabs?

Then active tab's audio will be controlled.

xyloflake commented 2 months ago

@staniel359 I and @gamersi have tried really hard but the method from the electron docs doesn't work. At all.

staniel359 commented 2 months ago

@xyloflake Have you tested with a packaged app?

xyloflake commented 2 months ago

@staniel359 I think we didn't iirc. @gamersi can you try a packaged app?

gamersi commented 2 months ago

I tried

xyloflake commented 2 months ago

@staniel359 nope it 100% doesn't work.