search

staniel359 / muffon

Advanced multi-source music streaming + discovery client for desktop. Free, clean, no login, no ads.
https://muffon.netlify.app
GNU Affero General Public License v3.0
1.18k stars 49 forks source link

Remove unnecessary packaged dependencies #137

Closed xyloflake closed 5 months ago

xyloflake commented 5 months ago

Vue is not required after building. This reduces packaged app size by ~1.8 MB. Please test a build before merging.

xyloflake commented 5 months ago

Just a lil’ extra reminder. Do NOT review without beta testing a build.

xyloflake commented 5 months ago

@gamersi please report packaged app size before/after the change.

gamersi commented 5 months ago

Delta & TL;DR:

Format DeltaSize
AppImage -3,3 MB
unpacked -14,1 MB
flatpak -1,1 MB
rpm -0,9 MB
pacman -3,3 MB
deb -3,3 MB

The difference for unpacked is - who would have thought - the largest coming in at 14,1 MB less disk usage

Numbers

Details:

package sizes from `main` branch: AppImage: 133,1 MB unpacked: 371,9 MB flatpak: 87,8 MB rpm: 83,8 MB pacman: 122,6 MB deb: 122,6 MB package sizes from `xyloflake-dependencies-fix` branch: AppImage: 129,8 MB unpacked: 357,8 MB flatpak: 86,7 MB rpm: 82,9 MB pacman: 119,3 MB deb: 119,3 MB

xyloflake commented 5 months ago

Yoohoo! That's a relief!

xyloflake commented 5 months ago

@gamersi @staniel359 please review.