search

staniel359 / muffon

Advanced multi-source music streaming + discovery client for desktop. Free, clean, no login, no ads.
https://muffon.netlify.app
GNU Affero General Public License v3.0
1.18k stars 49 forks source link

Quit does not work, have to force quit on MacOS #157

Open demensdeum opened 3 months ago

demensdeum commented 3 months ago

Steps:

  1. Run muffon on MacOS
  2. Close player window
  3. Muffon in still in Dock
  4. Right click on muffon in Dock -> Quit
  5. Doesn't close
  6. Optional key + right click on muffon -> Force quit
xyloflake commented 3 months ago

Hey! Nice to see ya again :)

That's actually intentional. You have to actually turn ON "exit on close" from the settings. image

Have a nice day!

demensdeum commented 3 months ago

Wow nice

demensdeum commented 3 months ago

But right-> quit should work as in other apps, for example Telegram @xyloflake

staniel359 commented 3 months ago

@demensdeum Hello. "Quit" in tray works as you described. "Quit" from context menu will behave the same as window's close button. I guess I should improve dock's context menu.

demensdeum commented 3 months ago

@staniel359 idea that vscode, telegram, Firefox, Google Chrome are closing entirely from dock -> right click-> context menu -> quit (process exits/killed) on MacOS, and muffin is still appear, and if window closed it looks like it stuck.

staniel359 commented 3 months ago

@demensdeum Got it, needs an improvement.

xyloflake commented 1 month ago

@staniel359 what's the proposed solution to this? Quit on calling quit from dock?

staniel359 commented 1 month ago

@xyloflake On Linux "Quit" from dock behaves like close button. And "Quit" from tray quits. I don't know for MacOS.

xyloflake commented 1 month ago

@staniel359 it's the same on macOS but the expected behaviour is to exit when you click on quit

staniel359 commented 1 month ago

@xyloflake Ok then.

xyloflake commented 1 month ago

@staniel359 ok what? Change the default setting to exit on close = true on macOS?

staniel359 commented 1 month ago

@xyloflake

the expected behaviour is to exit when you click on quit

Ok to this.

xyloflake commented 1 month ago

@staniel359 I mean we should just change the default value for macos right?

staniel359 commented 1 month ago

@staniel359 No. Person may not want to exit on close, but should be able to exit the app from dock/tray. So this "Quit" action in dock/tray should be redefined.

xyloflake commented 1 month ago

@staniel359 idt there's any way to differentiate the close button and quit from dock. Also, the red button on macOS is for closing the app and yellow is for minimising the app, why would anyone click close if they do not mean to close it?

staniel359 commented 1 month ago

@xyloflake Don't know about Mac, but on Windows "Close" can either exit or just close the window if tray is present. And minimize puts it in the taskbar.