Expr no-arg constructor

stanle / madopt

Apache License 2.0

16 stars 5 forks source link

Expr no-arg constructor #7

Closed paul-scott closed 7 years ago

paul-scott commented 7 years ago

Hey Karsten if you read this I'm putting up a few issues I have found with the C++ interface. If I get around to producing solutions I'll send you some pull requests.

An Expr constructed with no arguments seems to be in an unsafe state (have had it produce memory errors and over stack overflow). Few possible solutions:

If it is not used anywhere within the library remove it so that no one can accidentally use it
Give it some default behaviour, for example, have it create a zero integer

stanle commented 7 years ago

Hey Paul, I've addressed all of your issues in the new branch 'experimental'.

The empty Expr constructor is necessary for the python interface. I have set it to represent the number zero now.

paul-scott commented 7 years ago

Awesome mate thanks. These fixes will help prevent me from making the same mistakes in the future. I'll send you a separate email.