stanley-cheung / Protobuf-PHP

PHP implementation of Google's Protocol Buffers with a protoc plugin compiler
http://drslump.github.com/Protobuf-PHP/
MIT License
22 stars 11 forks source link

dependency on pear / pear's Console_CommandLine #17

Open philipmuir opened 7 years ago

philipmuir commented 7 years ago

How would you feel about swapping the dependency on pear and pear's Console_CommandLine to a composer library with a similar API, namely symfony/console?

I switched out Console_CommandLine for symfony/console here quickly: https://github.com/philipmuir/Protobuf-PHP/commit/a9c311fb121e87dd1d7786bddd504d5509467788

In the process I split the main console command in two, but looking back it's probably better to just keep it as one. A side effect was having to run protoc-gen-php proto:generate -o ./build tutorial.proto instead of protoc-gen-php -o ./build tutorial.proto.

I would be happy to take more time and refactor the commands keeping the same cli interface where possible.