Closed AndreaBorgia-Abo closed 5 years ago
Please hold off pulling this: I have to recheck if the higher volume of log output is causing OBD PIDs to be skipped during the loop.
Ok, go ahead, no problems with this PR. Turned out to be a timing issue: my car doesn't like too intense polling, apparently.... 250ms loop time works much better than the default 100ms.
SD data format is CSV based and includes a timestamp at first element for all lines.
Perhaps in telelogger, not in datalogger (please see the linked bug report!) I have plenty of files that are just sequences of "pid,value"
The virtual setTimestamp method in the base FileLogger class already handles the timestamp nicely, so the fix for #91 is simply to remove the barebones implementation from the SDLogger class. Now the first record of each block is always "PID" 0 with the timestamp. Please consider merging, thanks.