search

stanleyugwu / react-native-bottom-sheet

The tiny 📦, smart 😎, and flexible 🎗 bottom sheet your app craves
https://github.com/stanleyugwu/react-native-bottom-sheet#readme
MIT License
255 stars 9 forks source link

Upgrade to React Native 0.73.* #15

Open KevinvdBurg opened 7 months ago

KevinvdBurg commented 7 months ago

Hi,

Thanks for all the great work on this package.

I'm trying to update my project to React Native 0.73.4 and Expo 50 and I'm getting the follow error.=

npm ERR! node_modules/react-native
npm ERR!   react-native@"0.73.4" from the root project
npm ERR!   peer react-native@"*" from @devvie/bottom-sheet@0.3.0
npm ERR!   node_modules/@devvie/bottom-sheet
npm ERR!     @devvie/bottom-sheet@"^0.3.0" from the root project
npm ERR!   29 more (@expo/metro-runtime, ...)

Is it possible to upgrade this package to the latest version?

Thanks!

stanleyugwu commented 7 months ago

Oh! Thanks for letting me know, I'll bump to latest versions ASAP

stanleyugwu commented 7 months ago

Hey @KevinvdBurg ,

This issue most likely caused by un-versioned peer dependencies react and react-native.

Starting from npm 7+ the default behavior for peer dependencies have changed. From v7 up, packages need to specify a particular version for its peer dependencies, that's why npm throws an error when it sees * as a version.

I'll make the versions specific before the next release, but for now I guess you can use the --legacy-peer-deps flag to skip those error

stanleyugwu commented 7 months ago

Just fyi, I pushed the version bumps to develop