search

stanmaz / BBOalert

Automatic alert in BBO (BridgeBaseOnline)
9 stars 8 forks source link

Errors in Bridge Base Basic.txt #13

Open BSalita opened 1 year ago

BSalita commented 1 year ago

Found errors in Bridge Base Basic.txt. Both consider a bid which has already been made.

1S--2D--2S--,2S,13+ | 3-4 !S | Natural; game forcing
1S--2D--3S--,3S,Control showing cuebid
stanmaz commented 1 year ago

The algorithm is based on string matching (explicit of Regex). No analysis is performed if the coded bidding sequence makes sense or not. It is intentional because the data record can contain RegEx expressions or script calls or aliases making the strict "a priori" analysis impossible. The program uses what's usable and ignores the rest.

As the combination of the bidding context and the call in your example can not occur, it will be ignored.

BTW bridge laws allow insufficient bids if accepted by the opponents. So the sequence 1S--2D--2S--2S sequence is perfectly legal if the LHO passes or makes a bid. Unfortunately BBO makes insufficient bids impossible.

BSalita commented 1 year ago

Is either sequence a typo which should be corrected? Otherwise it can be safely be ignored? On Wednesday, April 26, 2023 at 04:56:00 AM EDT, stanmaz @.***> wrote:

The algorithm is based on string matching (explicit of Regex). No analysis is performed if the coded bidding sequence makes sense or not. It is intentional because the data record can contain RegEx expressions or script calls or aliases making the strict "a priori" analysis impossible. The program uses what's usable and ignores the rest.

As the combination of the bidding context and the call in your example can not occur, it will be ignored.

BTW bridge laws allow insufficient bids if accepted by the opponents. So the sequence 1S--2D--2S--2S sequence is perfectly legal if the LHO passes or makes a bid. Unfortunately BBO makes insufficient bids impossible.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

stanmaz commented 1 year ago

Where have you found the Basic.txt file ?

BSalita commented 1 year ago

The file path is "Systems/Bridge Base Basic.txt". I also worked with "BBO-Advanced.txt" and found the same kind of errors and, additionally, duplicate lines. The issue with duplicate lines, besides duplication, is they have different descriptions thus creating potential "failure to alert" conditions. On Thursday, April 27, 2023 at 03:45:13 AM EDT, stanmaz @.***> wrote:

Where have you found the Basic.txt file ?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>