Serial.flush modification breaks ATmega8 compiles

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?
1. Build arduino from latest source
2. set board type to something that uses an ATmega8 cpu.
3. Use "verify" to attempt compile of any sketch.

What is the expected output? What do you see instead?
It should work, but the compile of HardwareSerial.cpp fails due to TXC0 not 
being defined.  Since ATmega8 didn't number its (single) UART or UART bits, gcc 
can't compile the code.

Please use labels and text to provide additional information.
Broken by this patch, which uses TXC0 to allow Serial.flush to wait until the 
uart has really finished transmitting: 
https://github.com/arduino/Arduino/commit/f9f1d3af3ce73c7456a51503d3f7c7dcae0b75
e7

Patch attached.

Original issue reported on code.google.com by wes...@gmail.com on 29 Aug 2012 at 11:35

Attachments:

txc-patch.diff

GoogleCodeExporter commented 9 years ago

https://github.com/arduino/Arduino/commit/24c8bf8081e110a81267b5b67b3bf033f1f017
fc

Thanks for the patch!

Original comment by dmel...@gmail.com on 30 Aug 2012 at 12:53

Changed state: Fixed
Added labels: Component-Core, Milestone-1.0.2

GoogleCodeExporter commented 9 years ago

oops.  Leonardo is still broken :-(  At least that's "still broken" rather than 
"broken by the new patch."

Original comment by wes...@gmail.com on 30 Aug 2012 at 1:03

stannickel / arduino

Serial.flush modification breaks ATmega8 compiles #1019