stanstrup / PredRet

Shiny app for retention time prediction
GNU General Public License v2.0
9 stars 6 forks source link

upload error #80

Open HansVissers opened 4 years ago

HansVissers commented 4 years ago

Hello, The attached csv table creates an upload error. Thank you for looking into this, Hans

FDAtrain4PredRet.zip

1-28-2020 10-44-03 AM

stanstrup commented 4 years ago

Thanks for the report. The file appears to be correctly formatted.

Could you try making the pubchem column empty (but keeping the column)? The pull from pubchem doesn't work anymore. I don't remember if it uses that even if there is an inchi.

Could you also set the Method to "RPMMFDA" instead of "RPMM" so there is no confusion?

Neither of these things should make it break of course. But the system is not the most robust...

HansVissers commented 4 years ago

Dear Jan,

Thank you for the very prompt reply.

I initially tried to upload/process the file without the PubChem CIDs but this resulted in the same error. The method is set to "RPMMFDA".

Please let me know if you need any additional information for trouble shooting.

Best regards,

Hans

Hans Vissers Senior Consulting Scientist | Scientific Operations Waters Corporation

phone +44 161 435 4100 web www.waters.comhttp://www.waters.com/ email hans_vissers@waters.commailto:hans_vissers@waters.com Stamford Avenue | Altrincham Road, Wilmslow, SK9 4AX UK

Micromass UK Limited is registered in England under No 3162904 Registered Office: Stamford Avenue | Altrincham Road, Wilmslow, SK9 4AX

[cid:image001.gif@01D5D5CC.76636DD0]

From: Jan Stanstrup notifications@github.com Sent: Tuesday, January 28, 2020 11:13 AM To: stanstrup/PredRet PredRet@noreply.github.com Cc: Hans Vissers Hans_Vissers@waters.com; Author author@noreply.github.com Subject: [EXT] Re: [stanstrup/PredRet] upload error (#80)

ATTENTION: This email originated from outside of the organization. Please do not open any attachments or click any links unless you recognize the sender and know the content is safe.

Thanks for the report. The file appears to be correctly formatted.

Could you try making the pubchem column empty (but keeping the column)? The pull from pubchem doesn't work anymore. I don't remember if it uses that even if there is an inchi.

Could you also set the Method to "RPMMFDA" instead of "RPMM" so there is no confusion?

Neither of these things should make it break of course. But the system is not the most robust...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_stanstrup_PredRet_issues_80-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAH6UEINQCFETQJGKLOAJ2D3RAAALNA5CNFSM4KMPKLBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKCXUDY-23issuecomment-2D579172879&d=DwMCaQ&c=fiGwHnjCGAzy09rgJ-HQRw&r=WnTYV2BudHzr7HPlKvGDM8fA1O3K-gZYeb7sWpyeIt0&m=xnHHYOR3qceuzYn4f6at1eevA-1uO-j_1Ac-EkzQuBw&s=ctpBfdENLVhm2TAACEU2_P-EVjv1UXT8vRXcMqsVTqU&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AH6UEIOPFKN7ULCKKAMQJMTRAAALNANCNFSM4KMPKLBA&d=DwMCaQ&c=fiGwHnjCGAzy09rgJ-HQRw&r=WnTYV2BudHzr7HPlKvGDM8fA1O3K-gZYeb7sWpyeIt0&m=xnHHYOR3qceuzYn4f6at1eevA-1uO-j_1Ac-EkzQuBw&s=uIcdry7eFhtUdbndRQzS6-KojAtSzIuApgsqt4b6-Iw&e=.

====================================================================== The information in this email is confidential, and is intended solely for the addressee(s). Access to this email by anyone else is unauthorized and therefore prohibited. If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited and may be unlawful.

stanstrup commented 4 years ago

Yes you have selected that method but the file says "RPMM". As far as I remember what is in the CSV file overrules. Could you try changing that in the CSV?

Edit: incorrect apparently. The selection overrules.

HansVissers commented 4 years ago

Dear Jan,

Sorry, I misunderstood. I updated the csv file but I got the same error. The console reads the following:

JQMIGRATE: Migrate is installed, version 1.4.0 (index):113 Uncaught TypeError: Cannot set property 'value' of null at (index):113 (index):347 The specified value "NA" is not a valid number. The value must match to the following regular expression: -?(\d+|\d+.\d+|.\d+)([eE][-+]?\d+)? (index):356 The specified value "NA" is not a valid number. The value must match to the following regular expression: -?(\d+|\d+.\d+|.\d+)([eE][-+]?\d+)? (index):367 The specified value "NA" is not a valid number. The value must match to the following regular expression: -?(\d+|\d+.\d+|.\d+)([eE][-+]?\d+)? (index):376 The specified value "NA" is not a valid number. The value must match to the following regular expression: -?(\d+|\d+.\d+|.\d+)([eE][-+]?\d+)? (index):247 Uncaught TypeError: $ is not a function at Object.resizedCallback ((index):247) at a (iframeResizer.min.js:8) sockjs-0.3.min.js:27 WebSocket connection to 'ws://predret.org/shiny/shiny.apps/apps/retpred_shiny/retdb/sockjs/520/kp4pbdbz/websocket' failed: Error during WebSocket handshake: Unexpected response code: 400 y.websocket @ sockjs-0.3.min.js:27 2(index):247 Uncaught TypeError: $ is not a function at Object.resizedCallback ((index):247) at a (iframeResizer.min.js:8) shiny-server.js:210 Listening on http://127.0.0.1:38485 Loading required package: rJava Loading required package: xlsxjars Loading required package: Rcpp Warning: 'loadRcppModules' is deprecated. Use 'loadModule' instead. See help("Deprecated") Warning: replacing previous import ‘xcms::groups’ by ‘igraph::groups’ when loading ‘CAMERA’ Loading required package: RcppClassic Loading required package: ggplot2

Attaching package: ‘DT’

The following objects are masked from ‘package:shiny’:

dataTableOutput, renderDataTable

Warning: Unhandled error in observer: error in running command observe({ if (is.null(input$upload_go_Button)) return(NULL) if ((input$upload_go_Button) == 0) return(NULL) if (is.null(input$files)) return(NULL) if (any(unlist(lapply(data_cleaned()$errors, function(x) x$error == 1)))) return(NULL) isolate({ if (is.null(data_has_been_written$done)) { data_has_been_written$done <- 0L } else { data_has_been_written$done <- 0L } bson_data = mongo.bson.from.df(data_cleaned()$data) mongo <- PredRet_connect() wrote = mongo.insert.batch(mongo, PredRet.env$namespaces$ns_rtdata, bson_data) del <- mongo.disconnect(mongo) del <- mongo.destroy(mongo) data_has_been_written$done <- as.numeric(wrote) }) })

Best regards,

Hans

Hans Vissers Senior Consulting Scientist | Scientific Operations Waters Corporation

phone +44 161 435 4100 web www.waters.comhttp://www.waters.com/ email hans_vissers@waters.commailto:hans_vissers@waters.com Stamford Avenue | Altrincham Road, Wilmslow, SK9 4AX UK

Micromass UK Limited is registered in England under No 3162904 Registered Office: Stamford Avenue | Altrincham Road, Wilmslow, SK9 4AX

[cid:image001.gif@01D5D5D2.A5569120]

From: Jan Stanstrup notifications@github.com Sent: Tuesday, January 28, 2020 11:30 AM To: stanstrup/PredRet PredRet@noreply.github.com Cc: Hans Vissers Hans_Vissers@waters.com; Author author@noreply.github.com Subject: [EXT] Re: [stanstrup/PredRet] upload error (#80)

ATTENTION: This email originated from outside of the organization. Please do not open any attachments or click any links unless you recognize the sender and know the content is safe.

Yes you have selected that method but the file says "RPMM". As far as I remember what is in the CSV file overrules. Could you try changing that in the CSV?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_stanstrup_PredRet_issues_80-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAH6UEILMV5A5V3Q53I6UT2LRAACKFA5CNFSM4KMPKLBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKCZMBI-23issuecomment-2D579180037&d=DwMCaQ&c=fiGwHnjCGAzy09rgJ-HQRw&r=WnTYV2BudHzr7HPlKvGDM8fA1O3K-gZYeb7sWpyeIt0&m=8XxD1b_HKU37a8W5Bk7VbW15NW6PYwGDfArp7kLqeMM&s=kOWjNi4aYjX7hakTrrJzd-_OkHAZFKNPIZVYMiT-9m4&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AH6UEIIDRRE6N4UDUDL5CLTRAACKFANCNFSM4KMPKLBA&d=DwMCaQ&c=fiGwHnjCGAzy09rgJ-HQRw&r=WnTYV2BudHzr7HPlKvGDM8fA1O3K-gZYeb7sWpyeIt0&m=8XxD1b_HKU37a8W5Bk7VbW15NW6PYwGDfArp7kLqeMM&s=sNCKXdbcm9_OV4mlOd3qNK4yct2txk1-B0YoOzQ9drU&e=.

====================================================================== The information in this email is confidential, and is intended solely for the addressee(s). Access to this email by anyone else is unauthorized and therefore prohibited. If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited and may be unlawful.

stanstrup commented 4 years ago

Sorry for the goose chases.

I think I found the bug. At least I was able to crash it. The system uses obabel to clean up the structures and there is a limit to the length of the command that can be send. One of my functions is missing a safeguard for that apparently.

Can you try to dividing your file in two of approximately similar size? That solves that problem here.

HansVissers commented 4 years ago

Dear Jan,

Thanks for looking into this.

I will give that a try. Can I inform the software that 2 uploads need to be used to create a model? Thanks.

Best regards,

Hans

Hans Vissers Senior Consulting Scientist | Scientific Operations Waters Corporation

phone +44 161 435 4100 web www.waters.comhttp://www.waters.com/ email hans_vissers@waters.commailto:hans_vissers@waters.com Stamford Avenue | Altrincham Road, Wilmslow, SK9 4AX UK

Micromass UK Limited is registered in England under No 3162904 Registered Office: Stamford Avenue | Altrincham Road, Wilmslow, SK9 4AX

[cid:image001.gif@01D5D5E0.9B8DA6C0]

From: Jan Stanstrup notifications@github.com Sent: Tuesday, January 28, 2020 1:39 PM To: stanstrup/PredRet PredRet@noreply.github.com Cc: Hans Vissers Hans_Vissers@waters.com; Author author@noreply.github.com Subject: [EXT] Re: [stanstrup/PredRet] upload error (#80)

ATTENTION: This email originated from outside of the organization. Please do not open any attachments or click any links unless you recognize the sender and know the content is safe.

Sorry for the goose chases.

I think I found the bug. At least I was able to crash it. The system uses obabel to clean up the structures and there is a limit to the length of the command that can be send. One of my functions is missing a safeguard for that apparently.

Can you try to dividing your file in two of approximately similar size? That solves that problem here.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_stanstrup_PredRet_issues_80-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAH6UEILHJOCB3C6XEJQV6BTRAARNLA5CNFSM4KMPKLBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKDETGY-23issuecomment-2D579226011&d=DwMCaQ&c=fiGwHnjCGAzy09rgJ-HQRw&r=WnTYV2BudHzr7HPlKvGDM8fA1O3K-gZYeb7sWpyeIt0&m=thon40GD3SuwIhaGQXDad1XrSKw6w2mYMGybMwPuOn8&s=3F3htY9Zu8l6jO4w0kCCPBbGCd9Wczt6NABcmxuvlDQ&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AH6UEIIO3Q3VOUINHR2MGTDRAARNLANCNFSM4KMPKLBA&d=DwMCaQ&c=fiGwHnjCGAzy09rgJ-HQRw&r=WnTYV2BudHzr7HPlKvGDM8fA1O3K-gZYeb7sWpyeIt0&m=thon40GD3SuwIhaGQXDad1XrSKw6w2mYMGybMwPuOn8&s=36ivXlpH9A8ZCofsjvhHnVW3ZxTowAwtzVVuObM7U3o&e=.

====================================================================== The information in this email is confidential, and is intended solely for the addressee(s). Access to this email by anyone else is unauthorized and therefore prohibited. If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited and may be unlawful.

stanstrup commented 4 years ago

As long as they have the same "Method" all data will be used. If you are unlucky it makes the model based on the first set you upload. Then it will redo the model with all the data on the second pass. The system looks for new data every 10 minutes. It can take longer than that to finish the modeling though. If you give it a few hours it should be plenty to get all predictions possible.

HansVissers commented 4 years ago

On its way:

[cid:image001.png@01D5D5E2.3EC6D180]

From: Jan Stanstrup notifications@github.com Sent: Tuesday, January 28, 2020 1:47 PM To: stanstrup/PredRet PredRet@noreply.github.com Cc: Hans Vissers Hans_Vissers@waters.com; Author author@noreply.github.com Subject: [EXT] Re: [stanstrup/PredRet] upload error (#80)

ATTENTION: This email originated from outside of the organization. Please do not open any attachments or click any links unless you recognize the sender and know the content is safe.

As long as they have the same "Method" all data will be used. If you are unlucky it makes the model based on the first set you upload. Then it will redo the model with all the data on the second pass. The system looks for new data every 10 minutes. It can take longer than that to finish the modeling though. If you give it a few hours it should be plenty to get all predictions possible.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_stanstrup_PredRet_issues_80-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAH6UEIKPOJXGB535YS433WTRAASNNA5CNFSM4KMPKLBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKDFL2A-23issuecomment-2D579229160&d=DwMCaQ&c=fiGwHnjCGAzy09rgJ-HQRw&r=WnTYV2BudHzr7HPlKvGDM8fA1O3K-gZYeb7sWpyeIt0&m=GXK6WqkEPFPraeAEARVK3uG-nWwbFXEuNjO31dyLO3U&s=EnY_H_QjtJe03MjuTEiEiXlLBcV5jDgXPbmr7TJqVHc&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AH6UEIIEXLEBWJNDKDQLN63RAASNNANCNFSM4KMPKLBA&d=DwMCaQ&c=fiGwHnjCGAzy09rgJ-HQRw&r=WnTYV2BudHzr7HPlKvGDM8fA1O3K-gZYeb7sWpyeIt0&m=GXK6WqkEPFPraeAEARVK3uG-nWwbFXEuNjO31dyLO3U&s=UZKpZAA5EBVWsT-5OA3Bt5vj7cbxvVuQju-GEbVcpro&e=.

====================================================================== The information in this email is confidential, and is intended solely for the addressee(s). Access to this email by anyone else is unauthorized and therefore prohibited. If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited and may be unlawful.

stanstrup commented 4 years ago

your image didn't survive email --> github. Can you put on github directly?

HansVissers commented 4 years ago

1-28-2020 2-28-10 PM

Here it is!

stanstrup commented 4 years ago

Ah. So it did work!

All good?

HansVissers commented 4 years ago

Yes, I assume that the “system” will become available once the model has been created. Thanks.

From: Jan Stanstrup notifications@github.com Sent: Tuesday, January 28, 2020 2:39 PM To: stanstrup/PredRet PredRet@noreply.github.com Cc: Hans Vissers Hans_Vissers@waters.com; Author author@noreply.github.com Subject: [EXT] Re: [stanstrup/PredRet] upload error (#80)

ATTENTION: This email originated from outside of the organization. Please do not open any attachments or click any links unless you recognize the sender and know the content is safe.

Ah. So it did work!

All good?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_stanstrup_PredRet_issues_80-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAH6UEINJIGBSXUOP6T2LUALRAAYNXA5CNFSM4KMPKLBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKDKLBI-23issuecomment-2D579249541&d=DwMCaQ&c=fiGwHnjCGAzy09rgJ-HQRw&r=WnTYV2BudHzr7HPlKvGDM8fA1O3K-gZYeb7sWpyeIt0&m=GCPTYphEG2dtImI5-wU0GUVE-yB6pA1c83lXVNpJwcs&s=jAOMpxXV7e_qnm2MOlV-O5wUl91iPd8quRNaI3jQwos&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AH6UEIN2SZXS4S6E74B4L7LRAAYNXANCNFSM4KMPKLBA&d=DwMCaQ&c=fiGwHnjCGAzy09rgJ-HQRw&r=WnTYV2BudHzr7HPlKvGDM8fA1O3K-gZYeb7sWpyeIt0&m=GCPTYphEG2dtImI5-wU0GUVE-yB6pA1c83lXVNpJwcs&s=JleIcozp6JuCHVRZWRwfF8wYlLAuUN3FeEF_D1I_61o&e=.

====================================================================== The information in this email is confidential, and is intended solely for the addressee(s). Access to this email by anyone else is unauthorized and therefore prohibited. If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited and may be unlawful.

stanstrup commented 4 years ago

A thousand predictions now available ;)

I will leave this open as the underlying bug is not fixed.

YunyunZHU commented 4 years ago

Hello, stanstrup,

I've tried to split my file into three parts, each has about 15 compounds. And I have Pubchem column even if they are all empty. But I still get the error message identical to HansVissers. I'm wondering what else I can do to solve this? Looking forward to hearing from you! Thank you!