stape-io / gtm-server-side-magento-module

Stape GTM Server Side Magento Module
https://stape.io/apps
GNU General Public License v3.0
4 stars 3 forks source link

Unnecessary difficulty in implementing additional attributes in the data layer. #13

Closed elisei closed 4 months ago

elisei commented 5 months ago

Hello,

I need to customize the sent attributes and encountered some difficulties.

There is no reason for the functions to be private:

ViewModel/Success.php ViewModel/Product.php ViewModel/Checkout.php ViewModel/Category.php ViewModel/Cart.php

This makes extending them to implement custom attributes nearly impossible and may cause compatibility issues in the future.

Additionally, you should not indicate the column standard in the module.