search

stapi-spec / stapi-fastapi

Spatio Temporal Asset Tasking with FastAPI
MIT License
12 stars 4 forks source link

Add self link and a create-order rel link to OpportunityCollection returned by the product_router #92

Closed parksjr closed 1 week ago

parksjr commented 2 weeks ago

See comment on pr #80 here: https://github.com/stapi-spec/stapi-fastapi/pull/80#discussion_r1826116590

Also extend this for OrderCollection. background: we are changing the get_orders endpoint to return an OrderCollection (like OpportunityCollection) instead of list[Order] see comment on pr #80 here: https://github.com/stapi-spec/stapi-fastapi/pull/80#discussion_r1826101918

jkeifer commented 2 weeks ago

I found #47 does address the OpportunityCollection link. I am not sure it can be rebased effectively at this point, but the code there might serve as an effective start at implementing that link.

philvarner commented 1 week ago

I'm going to add the create-order link, but it's not conventional for a search endpoint like /opportunities to return a self link unless there's actually an identifiable persistent resource created