star-39 / moe-sticker-bot

A Telegram bot that imports LINE/kakao stickers or creates/manages new sticker set.
GNU General Public License v3.0
272 stars 31 forks source link

Edit Emoji doesn't always work #15

Closed worker8 closed 2 years ago

worker8 commented 2 years ago

Thanks for the awesome project! 🥇

I want to report a bug 🐛 .

Here's the step that I have taken:

Screen Shot 2022-05-18 at 22 01 06

But after doing this, the following sticker doesn't get assigned to 👀 . It still remains as the emoji that it was previously assigned.

Screen Shot 2022-05-18 at 22 04 28
star-39 commented 2 years ago

Thank you for reporting!

I will investigate this issue tomorrow.

Since Telegram does not support editing directly through API, current "editing" was done by

  1. Uploading a new sticker with emoji specified.
  2. Move the newly uploaded sticker to previous position.
  3. Delete the previous sticker.

This step is complex and might result unexpected error(eg. Flood Limit)

I'm planning to optimize these steps.

worker8 commented 2 years ago

Thanks for your quick reply!

I just checked this morning, I noticed that the sticker has already been assigned to the new emoji.

Since Telegram does not support editing directly through API, current "editing" was done by Uploading a new sticker with emoji specified. Move the newly uploaded sticker to previous position. Delete the previous sticker.

Awesome method to get around the lack of edit API. 👍

Perhaps due to the fact that there's no direct API for editing, plus the extra steps needed, when I re-open the sticker pack right after editing the emoji, I am still looking at the old sticker, not the new one. Hence the old emoji.