star-bnl / star-sw

Core software for STAR experiment
26 stars 63 forks source link

Replacing sys/types.h with stdint.h #213

Closed veprbl closed 1 month ago

veprbl commented 2 years ago

This is a tracking issue to replace non-standard types with types defined in the ISO C and C++ standards. Specifically, the following:

The ultimate goal is to get rid of unnecessary includes of sys/types.h. This will help with ROOT5 being incompatible with the newest versions of libc (see https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/science/misc/root/purify_include_paths_root5.patch for an alternative solution).

plexoos commented 1 year ago

I don't think we have any _BSD_SOURCE in the code

veprbl commented 1 year ago

I don't remember what I was thinking, but it is probably controlled via other settings implemented in libc's. In any case, this can't be done unless we get rid of using that functionality first, which I don't think is going to happen at this point (we are blocked on having Jeff do the work on VxWorks bits).

plexoos commented 1 year ago

443 should take care of the StRoot/StGenericVertexMaker bullet

fgeurts commented 1 month ago

Hi @veprbl and @plexoos, Is this issue still tracking the non-standard type replacements? It hasn't been updated in a couple of years. Should we leave it open, assign to others, or has this been addressed and we should close it. Please advise.

veprbl commented 1 month ago

We weren't able to complete this migration fully. This is not a strict requirement for ROOT6-based builds. Let's close.