Closed marrbnl closed 2 years ago
It looks like it is submitted against the main branch. Should I submit to "JevpProduction" branch? If so, how can I do that? Thanks.
@marrbnl You can click "Edit" button to the right of your PR's title, then change the value of the "base:" dropdown menu. You might need to do git rebase -i JevpProduction
to remove unrelated commits and git push -f
after that.
Sorry for the noise, guys.
@marrbnl You didn't do anything wrong. It's a known GitHub bug with CODEOWNERS and base change. It just needs a rebase and force push (I guess in this case you should first do that).
Here is what I did: git rebase JevpProduction git push -f origin rma-online-mtd
I changed the base from main to JevpProduction for this PR, but now it says my PR requests 40 commits, which seems wrong
git rebase -i JevpProduction
, then remove all lines except the one with your commit, save, exit, then git push -f
When I do "git rebase -i JevpProduction", only an empty scratch pops up. I do not see any commits
You almost made it. Judging from git log be0c68b85e --format=full
you've closed the file without removing the extra commit history from "main". I've fixed it by basically doing a rebase
again: https://asciinema.org/a/ydvQfiB2yzsTqpan6gpGXIhxo
Thanks very much.
Code changes look fine.
Thanks for reopening. I mixed up my review/approval buttons.
Do we understand the failure in CI Build with ROOT5? Can we fix it and move the request forward? Thanks
The failure on the "JevpProduction" branch is a known issue and needs to be addressed separately from this PR.
Closing this old PR. Jevp is update-to-date with a recent PR by Jeff. https://github.com/star-bnl/star-sw/pull/292
@marrbnl Did you mean to submit this against the "JevpProduction" branch?