Misalignment updates FST and Simplified FST Geometry

[klendathu2k]

Updates to misalignment tables (names, correct timestamps, etc...) for the FST. Implementation of simplified FST geometry model for track reconstruction. Support for misaligned geometries in g2t_volume_id.

[klendathu2k]

Depends on whether forward tracking is to be supported with y2022a. If we limit ourselves to support central tracking with the y2022a tag, I can define that tomorrow. Otherwise, I have to double check where we are on the sTGC.

On 2022-01-25 11:47, Gene Van Buren wrote:

@genevb commented on this pull request.

I don't have much to speak of on any of this PR (I'm sure misalignment will be useful). A tangential question though: what else is needed for y2022a?

-- Reply to this email directly, view it on GitHub [1], or unsubscribe [2]. Triage notifications on the go with GitHub Mobile for iOS [3] or Android [4]. You are receiving this because you were assigned.Message ID: @.***>

Links:

[1] https://github.com/star-bnl/star-sw/pull/285#pullrequestreview-862578744 [2] https://github.com/notifications/unsubscribe-auth/ANL4LVDWJXH3TCTLARJY2OLUX3H2ZANCNFSM5MYUZBBA [3] https://urldefense.com/v3/__https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675__;!!P4SdNyxKAPE!UHl1kHJRHTQwC75YtuA2_OPEtj8yG6itdC5S16SG_RnlBfdoMWwuSGpZ2ZxkSF8$ [4] https://urldefense.com/v3/__https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign*3Dnotification-email*26utm_medium*3Demail*26utm_source*3Dgithub__;JSUlJSU!!P4SdNyxKAPE!UHl1kHJRHTQwC75YtuA2_OPEtj8yG6itdC5S16SG_RnlBfdoMWwuSGpZ37x8nhM$

[genevb]

Depends on whether forward tracking is to be supported with y2022a. If we limit ourselves to support central tracking with the y2022a tag, I can define that tomorrow.

If you define y2022a now (sans forward tracking), is there any difference from y2022 (initial)?

[klendathu2k]

There should not be. It will be a straight y2022 --> y2022a copy.
There have been no updates outside of the forward detectors.

On 2022-01-25 13:21, Gene Van Buren wrote:

Depends on whether forward tracking is to be supported with y2022a. If we limit ourselves to support central tracking with the y2022a tag, I can define that tomorrow.

If you define y2022a now (sans forward tracking), is there any difference from y2022 (initial)?

-- Reply to this email directly, view it on GitHub [1], or unsubscribe [2]. Triage notifications on the go with GitHub Mobile for iOS [3] or Android [4]. You are receiving this because you were assigned.Message ID: @.***>

Links:

[1] https://github.com/star-bnl/star-sw/pull/285#issuecomment-1021478658 [2] https://github.com/notifications/unsubscribe-auth/ANL4LVAZR4F6S7V3CUCS47LUX3S2ZANCNFSM5MYUZBBA [3] https://urldefense.com/v3/__https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675__;!!P4SdNyxKAPE!UPX-TW3rOjXRMwSI6WTSz5mQ1r9-gK_akkqoTxmcq9y_xjtiXs8o3-5C_R2Qe3k$ [4] https://urldefense.com/v3/__https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign*3Dnotification-email*26utm_medium*3Demail*26utm_source*3Dgithub__;JSUlJSU!!P4SdNyxKAPE!UPX-TW3rOjXRMwSI6WTSz5mQ1r9-gK_akkqoTxmcq9y_xjtiXs8o3-5CUycmYm4$

[genevb]

There should not be. It will be a straight y2022 --> y2022a copy. There have been no updates outside of the forward detectors.

Thanks for the reply. In that case, I am not pressing for freezing y2022a now.

[plexoos]

Should we store the misalignment values from StarDb/Geometry/fst/*.C in the database instead?

[klendathu2k]

@plexoos The misalignments are not expected to vary over the course of the run, so we only expect one entry once they have been measured. The practice for HFT misalignments, and I believe TPC and others as well, has been to store them StarDb area.

[klendathu2k]

@genevb @perevbnlgov This geometry update is stalled waiting for a code owner to approve. Could one of you have a look? Thanks.

[genevb]

The misalignments are not expected to vary over the course of the run, so we only expect one entry once they have been measured. The practice for HFT misalignments, and I believe TPC and others as well, has been to store them StarDb area.

For the TPC, I think surveys and ideal geometries have been stored as CINT files, but the misalignments used in production are stored in the database. If my memory serves me correctly, I think for the HFT that the CINT files were generated from the database tables, but I could be wrong.

-Gene

[klendathu2k]

Looks like trigger simulator is breaking tests?

[genevb]

Looks like trigger simulator is breaking tests?

I have created an issue: #303 .

-Gene

[veprbl]

FYI I've restarted CI after #304 was merged, the tests are green again

[starsdong]

Are we good with this one? @jdbrice or @perevbnlgov need your approval to proceed.

[starsdong]

Dmitri, let us move ahead and merge this in then. Thanks