search

star-bnl / star-sw

Core software for STAR experiment
26 stars 63 forks source link

Update to trigger simulator to save intermediate jet patch ADCs and minor cleanup to the jet maker #424

Closed zlchang closed 1 year ago

zlchang commented 1 year ago

1) Update to the trigger simulator to save the intermediate jet patch sum ADCs and make them available to access for analysis. In this case save the 30 jet patch ADCs in the StJetSkimEvent. 2) Remove unnecessary printouts in the StJetMaker2012 during the UE offaxis cone calculation

Not urgent! May add additional edits if necessary.

plexoos commented 1 year ago

Not urgent! May add additional edits if necessary.

You can mark it as draft until it's ready. Also, could you please give it a concise title and put details in the description? By default the final commit will inherit that from the PR when we squash and merge. Thanks

zlchang commented 1 year ago

Hi guys, any comment on this request?

plexoos commented 1 year ago

Hi guys, any comment on this request?

Did you see the comment from Jason? Can you change the title of this PR as suggested?

zlchang commented 1 year ago

1) Update to the trigger simulator to save the intermediate jet patch sum ADCs and make them available to access for analysis. In this case save the 30 jet patch ADCs in the StJetSkimEvent. 2) Remove unnecessary printouts in the StJetMaker2012 during the UE offaxis cone calculation

plexoos commented 1 year ago

Unrelated to this PR but related to the modified files you are the owner of. There is a bunch of compiler warnings coming from StRoot/StTriggerUtilities/Bemc/StBemcTriggerSimu.cxx and StRoot/StTriggerUtilities/Eemc/StEemcTriggerCompare.cxx. Could you please address them in a separate PR?

zlchang commented 1 year ago

Okay I will look at the warning message and try to correct them.

Unrelated to this PR but related to the modified files you are the owner of. There is a bunch of compiler warnings coming from StRoot/StTriggerUtilities/Bemc/StBemcTriggerSimu.cxx and StRoot/StTriggerUtilities/Eemc/StEemcTriggerCompare.cxx. Could you please address them in a separate PR?

zlchang commented 1 year ago

Any comments or suggestions, @akioogawa @jml985 and @veprbl

zlchang commented 1 year ago

Hi Akio @akioogawa and Jeff @jml985, any comment or question? In case you missed it, I also presented this update to our cold qcd group. https://drupal.star.bnl.gov/STAR/system/files/run17trgSimu.pdf

plexoos commented 1 year ago

If you don't get a response from the nominal code owners in a reasonable time, just let us know here and we'll merge.

starsdong commented 1 year ago

Dmitri, I would suggest to merge this one after this branch is synced with the main. Thanks

starsdong commented 1 year ago

Zilong, could you please update your branch to be sync with main? Then after the CI checks out, let us merge this PR then. Thanks

plexoos commented 1 year ago

Xin, are you approving this PR?

zlchang commented 1 year ago

Hi Xin and Dmitry,

I think it is the time to merge the pull request into the main. I also come up with a few fixes to suppress the warning messages from StBemcSimuMaker and StEemcTriggerCompare that Dmitry had mentioned before. I can put them in this request or I can submit another request. Let me know which option is better for you.

Zilong

On Dec 6, 2022, at 8:55 PM, Dmitri Smirnov @.***> wrote:



Xin, are you approving this PR?

— Reply to this email directly, view it on GitHubhttps://github.com/star-bnl/star-sw/pull/424#issuecomment-1340265693, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGH7F3MMOP2S3OYYSRPLYHDWL7VAPANCNFSM6AAAAAARQPHJII. You are receiving this because you authored the thread.Message ID: @.***>

plexoos commented 1 year ago

Hi Zilong, Yes, please address compiler warnings in another pull request as we discussed. Thank you.