star-bnl / star-sw

Core software for STAR experiment
26 stars 63 forks source link

Undeclared detector identifiers from StEvent's 'enum StDetectorId' #454

Closed plexoos closed 1 month ago

plexoos commented 1 year ago

In the ROOT6 test jobs we see the following errors which, I believe, are related to the call of detectorNameById() in StiStEventFiller::fillEvent()

https://github.com/star-bnl/star-sw/blob/6d54584190f588e0ccbe96c50fd17c1ffdd8681a/StRoot/StiMaker/StiStEventFiller.cxx#L808

Although detectorId(int*, char**) is now compiled (#440) there is still a call to the ROOT6 "interpreter" inside that function that may be the reason for the observed errors.

https://github.com/star-bnl/star-sw/blob/6d54584190f588e0ccbe96c50fd17c1ffdd8681a/StRoot/StEvent/StEnumerations.cxx#L60

I can't think of a better way to address this issue but to refactor the detectorId() function with a swith case for enum to string as suggested in https://github.com/star-bnl/star-sw/pull/440#issuecomment-1316304365

Expand to see error messages ``` input_line_740:2:2: error: use of undeclared identifier 'kUnknownId' StEvent Error Summary: kUnknownId ^ 0 - 0( 0) 1 - 21( 27) //mFlag: is Negative input_line_741:2:2: error: use of undeclared identifier 'kTpcId' kTpcId ^ input_line_742:2:2: error: use of undeclared identifier 'kSvtId' kSvtId ^ input_line_743:2:2: error: use of undeclared identifier 'kRichId' kRichId ^ input_line_744:2:2: error: use of undeclared identifier 'kFtpcWestId' kFtpcWestId ^ input_line_745:2:2: error: use of undeclared identifier 'kFtpcEastId' kFtpcEastId ^ input_line_746:2:2: error: use of undeclared identifier 'kTofId' kTofId ^ input_line_747:2:2: error: use of undeclared identifier 'kBTofId' kBTofId ^ input_line_748:2:2: error: use of undeclared identifier 'kCtbId' kCtbId ^ input_line_749:2:2: error: use of undeclared identifier 'kSsdId' kSsdId ^ input_line_750:2:2: error: use of undeclared identifier 'kBarrelEmcTowerId' kBarrelEmcTowerId ^ input_line_751:2:2: error: use of undeclared identifier 'kBarrelEmcPreShowerId' kBarrelEmcPreShowerId ^ input_line_752:2:2: error: use of undeclared identifier 'kBarrelSmdEtaStripId' kBarrelSmdEtaStripId ^ input_line_753:2:2: error: use of undeclared identifier 'kBarrelSmdPhiStripId' kBarrelSmdPhiStripId ^ input_line_754:2:2: error: use of undeclared identifier 'kEndcapEmcTowerId' kEndcapEmcTowerId ^ input_line_755:2:2: error: use of undeclared identifier 'kEndcapEmcPreShowerId' kEndcapEmcPreShowerId ^ input_line_756:2:2: error: use of undeclared identifier 'kEndcapSmdUStripId' kEndcapSmdUStripId ^ input_line_757:2:2: error: use of undeclared identifier 'kEndcapSmdVStripId' kEndcapSmdVStripId ^ input_line_758:2:2: error: use of undeclared identifier 'kZdcWestId' kZdcWestId ^ input_line_759:2:2: error: use of undeclared identifier 'kZdcEastId' kZdcEastId ^ input_line_760:2:2: error: use of undeclared identifier 'kMwpcWestId' kMwpcWestId ^ input_line_761:2:2: error: use of undeclared identifier 'kMwpcEastId' kMwpcEastId ^ input_line_762:2:2: error: use of undeclared identifier 'kTpcSsdId' kTpcSsdId ^ input_line_763:2:2: error: use of undeclared identifier 'kTpcSvtId' kTpcSvtId ^ input_line_764:2:2: error: use of undeclared identifier 'kTpcSsdSvtId' kTpcSsdSvtId ^ input_line_765:2:2: error: use of undeclared identifier 'kSsdSvtId' kSsdSvtId ^ input_line_766:2:2: error: use of undeclared identifier 'kPhmdCpvId' kPhmdCpvId ^ input_line_767:2:2: error: use of undeclared identifier 'kPhmdId' kPhmdId ^ input_line_768:2:2: error: use of undeclared identifier 'kPxlId' kPxlId ^ input_line_769:2:2: error: use of undeclared identifier 'kIstId' kIstId ^ input_line_770:2:2: error: use of undeclared identifier 'kFgtId' kFgtId ^ input_line_771:2:2: error: use of undeclared identifier 'kEtrId' kEtrId ^ input_line_772:2:2: error: use of undeclared identifier 'kFpdWestId' kFpdWestId ^ input_line_773:2:2: error: use of undeclared identifier 'kFpdEastId' kFpdEastId ^ input_line_774:2:2: error: use of undeclared identifier 'kFmsId' kFmsId ^ input_line_775:2:2: error: use of undeclared identifier 'kRpsId' kRpsId ^ input_line_776:2:2: error: use of undeclared identifier 'kMtdId' kMtdId ^ input_line_777:2:2: error: use of undeclared identifier 'kSstId' kSstId ^ input_line_778:2:2: error: use of undeclared identifier 'kGmtId' kGmtId ^ input_line_779:2:2: error: use of undeclared identifier 'kFtsId' kFtsId ^ input_line_780:2:2: error: use of undeclared identifier 'kiTpcId' kiTpcId ^ input_line_781:2:2: error: use of undeclared identifier 'kETofId' kETofId ^ input_line_782:2:2: error: use of undeclared identifier 'kFcsWcalId' kFcsWcalId ^ input_line_783:2:2: error: use of undeclared identifier 'kFcsHcalId' kFcsHcalId ^ input_line_784:2:2: error: use of undeclared identifier 'kFcsPresId' kFcsPresId ^ input_line_785:2:2: error: use of undeclared identifier 'kFttId' kFttId ^ input_line_786:2:2: error: use of undeclared identifier 'kFstId' kFstId ^ input_line_787:2:2: error: use of undeclared identifier 'kMaxDetectorId' kMaxDetectorId ^ 0 = kUnknownId 0 = kTpcId 0 = kSvtId 0 = kRichId 0 = kFtpcWestId 0 = kFtpcEastId 0 = kTofId 0 = kBTofId 0 = kCtbId 0 = kSsdId 0 = kBarrelEmcTowerId 0 = kBarrelEmcPreShowerId 0 = kBarrelSmdEtaStripId 0 = kBarrelSmdPhiStripId 0 = kEndcapEmcTowerId 0 = kEndcapEmcPreShowerId 0 = kEndcapSmdUStripId 0 = kEndcapSmdVStripId 0 = kZdcWestId 0 = kZdcEastId 0 = kMwpcWestId 0 = kMwpcEastId 0 = kTpcSsdId 0 = kTpcSvtId 0 = kTpcSsdSvtId 0 = kSsdSvtId 0 = kPhmdCpvId 0 = kPhmdId 0 = kPxlId 0 = kIstId 0 = kFgtId 0 = kEtrId 0 = kFpdWestId 0 = kFpdEastId 0 = kFmsId 0 = kRpsId 0 = kMtdId 0 = kSstId 0 = kGmtId 0 = kFtsId 0 = kiTpcId 0 = kETofId 0 = kFcsWcalId 0 = kFcsHcalId 0 = kFcsPresId 0 = kFttId 0 = kFstId 0 = kMaxDetectorId ```

https://github.com/star-bnl/star-sw/actions/runs/3584685141/jobs/6033757193#step:5:2757

fgeurts commented 1 month ago

Hi, @plexoos @genevb - Should this issue still be open? I noticed that #658 was closed last February.

fgeurts commented 1 month ago

Propose to close this ticket as per previous comment.