Closed klendathu2k closed 7 months ago
klendathu2k
commented
7 months ago I don't really know anything about GeoTestMaker and I offer no comment on its removal.
GeoTestMaker is essentially just a set of Stv utility classes. There are no other packages in our repo that depend upon it... at least nothing showed up when (1) I grepped the codebase, and (2) I ran cons.
genevb
commented
7 months ago A simple search for files with "Stv" in their name reveals several other files that can probably also be removed from the library along with the Stv package, since it is unlikely that anything else uses these files.
StDb/idl/StvHitErrs.idl
StDb/idl/StvKonst.idl
StDb/idl/StvTpcHitErrs.idl
StRoot/StGenericVertexMaker/StvPPVertex
StRoot/macros/calib/StvFitErr.C
StRoot/macros/calib/StvFitErr.csh
StRoot/macros/calib/runStv.C
StarDb/Calibrations/tracker/StvIstHitErrs.C
StarDb/Calibrations/tracker/StvKonst.C
StarDb/Calibrations/tracker/StvPxlHitErrs.C
StarDb/Calibrations/tracker/StvTpcInnerHitErrs.20090315.000000.C
StarDb/Calibrations/tracker/StvTpcInnerHitErrs.20100101.000000.C
StarDb/Calibrations/tracker/StvTpcInnerHitErrs.C
StarDb/Calibrations/tracker/StvTpcInnerHitErrs.y2009c.C
StarDb/Calibrations/tracker/StvTpcInnerHitErrs.y2010c.C
StarDb/Calibrations/tracker/StvTpcInnerHitErrs.y2011c.C
StarDb/Calibrations/tracker/StvTpcInnerPromptErrs.C
StarDb/Calibrations/tracker/StvTpcOuterHitErrs.20090315.000000.C
StarDb/Calibrations/tracker/StvTpcOuterHitErrs.20100101.000000.C
StarDb/Calibrations/tracker/StvTpcOuterHitErrs.C
StarDb/Calibrations/tracker/StvTpcOuterHitErrs.y2009c.C
StarDb/Calibrations/tracker/StvTpcOuterHitErrs.y2010c.C
StarDb/Calibrations/tracker/StvTpcOuterHitErrs.y2011c.C
StarDb/Calibrations/tracker/StvTpcOuterPromptErrs.C-Gene
klendathu2k
commented
7 months ago Hi Gene,
... and doing a grep for Stv reminds me that 1) There are build instructions for Stv in cons, and 2) There are chain options defined in StBFChain
... will look more closely when I have a chance.
Jason
On 2023-10-17 11:10, Gene Van Buren wrote:
A simple search for files with "Stv" in their name reveals several other files that can probably also be removed from the library along with the Stv package, since it is unlikely that anything else uses these files.
StDb/idl/StvHitErrs.idl StDb/idl/StvKonst.idl StDb/idl/StvTpcHitErrs.idl StRoot/StGenericVertexMaker/StvPPVertex StRoot/macros/calib/StvFitErr.C StRoot/macros/calib/StvFitErr.csh StRoot/macros/calib/runStv.C StarDb/Calibrations/tracker/StvIstHitErrs.C StarDb/Calibrations/tracker/StvKonst.C StarDb/Calibrations/tracker/StvPxlHitErrs.C StarDb/Calibrations/tracker/StvTpcInnerHitErrs.20090315.000000.C StarDb/Calibrations/tracker/StvTpcInnerHitErrs.20100101.000000.C StarDb/Calibrations/tracker/StvTpcInnerHitErrs.C StarDb/Calibrations/tracker/StvTpcInnerHitErrs.y2009c.C StarDb/Calibrations/tracker/StvTpcInnerHitErrs.y2010c.C StarDb/Calibrations/tracker/StvTpcInnerHitErrs.y2011c.C StarDb/Calibrations/tracker/StvTpcInnerPromptErrs.C StarDb/Calibrations/tracker/StvTpcOuterHitErrs.20090315.000000.C StarDb/Calibrations/tracker/StvTpcOuterHitErrs.20100101.000000.C StarDb/Calibrations/tracker/StvTpcOuterHitErrs.C StarDb/Calibrations/tracker/StvTpcOuterHitErrs.y2009c.C StarDb/Calibrations/tracker/StvTpcOuterHitErrs.y2010c.C StarDb/Calibrations/tracker/StvTpcOuterHitErrs.y2011c.C StarDb/Calibrations/tracker/StvTpcOuterPromptErrs.C
-Gene
-- Reply to this email directly, view it on GitHub [1], or unsubscribe [2]. You are receiving this because you authored the thread.Message ID: @.***>
Links:
[1] https://github.com/star-bnl/star-sw/pull/603#issuecomment-1766619125 [2] https://github.com/notifications/unsubscribe-auth/ANL4LVHHETHLSFOV4MNE4N3X72NVDAVCNFSM6AAAAAA5557HCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRWGYYTSMJSGU
klendathu2k
commented
7 months ago Drafting a new PR #607 to remove these files, and cleanup a some additional Stv "dependencies"... BFC options and StXTrakMaker. We'll see if it passes the CI tests.
On 2023-10-17 11:10, Gene Van Buren wrote:
A simple search for files with "Stv" in their name reveals several other files that can probably also be removed from the library along with the Stv package, since it is unlikely that anything else uses these files.
StDb/idl/StvHitErrs.idl StDb/idl/StvKonst.idl StDb/idl/StvTpcHitErrs.idl StRoot/StGenericVertexMaker/StvPPVertex StRoot/macros/calib/StvFitErr.C StRoot/macros/calib/StvFitErr.csh StRoot/macros/calib/runStv.C StarDb/Calibrations/tracker/StvIstHitErrs.C StarDb/Calibrations/tracker/StvKonst.C StarDb/Calibrations/tracker/StvPxlHitErrs.C StarDb/Calibrations/tracker/StvTpcInnerHitErrs.20090315.000000.C StarDb/Calibrations/tracker/StvTpcInnerHitErrs.20100101.000000.C StarDb/Calibrations/tracker/StvTpcInnerHitErrs.C StarDb/Calibrations/tracker/StvTpcInnerHitErrs.y2009c.C StarDb/Calibrations/tracker/StvTpcInnerHitErrs.y2010c.C StarDb/Calibrations/tracker/StvTpcInnerHitErrs.y2011c.C StarDb/Calibrations/tracker/StvTpcInnerPromptErrs.C StarDb/Calibrations/tracker/StvTpcOuterHitErrs.20090315.000000.C StarDb/Calibrations/tracker/StvTpcOuterHitErrs.20100101.000000.C StarDb/Calibrations/tracker/StvTpcOuterHitErrs.C StarDb/Calibrations/tracker/StvTpcOuterHitErrs.y2009c.C StarDb/Calibrations/tracker/StvTpcOuterHitErrs.y2010c.C StarDb/Calibrations/tracker/StvTpcOuterHitErrs.y2011c.C StarDb/Calibrations/tracker/StvTpcOuterPromptErrs.C
-Gene
-- Reply to this email directly, view it on GitHub [1], or unsubscribe [2]. You are receiving this because you authored the thread.Message ID: @.***>
Links:
[1] https://github.com/star-bnl/star-sw/pull/603#issuecomment-1766619125 [2] https://github.com/notifications/unsubscribe-auth/ANL4LVHHETHLSFOV4MNE4N3X72NVDAVCNFSM6AAAAAA5557HCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRWGYYTSMJSGU
Removing GeoTestMaker and Stv codes from the main branch, as they no longer compile under root 6.24 and are (to my knowledge) not in use and not actively maintained.