star-bnl / star-sw

Core software for STAR experiment
26 stars 63 forks source link

[Geometry/y2024] First cut (and first production cut) of the y2024 geometry model #622

Closed klendathu2k closed 6 months ago

klendathu2k commented 6 months ago

Ident to y2023... STAR has reached a point of stability in its evolution...

klendathu2k commented 1 month ago

Fixed w/ PR #670.

On 2024-03-20 00:06, Gene Van Buren wrote:

@genevb commented on this pull request.

In StRoot/StChain/GeometryDbAliases.h [1]:

@@ -162,6 +162,9 @@ static const DbAlias_t fDbAlias[] = {// geometry Comment old { "y2023", 20230410, 0, "y2023", "y2023 first cut geometry, AgML,xgeometry"}, { "y2023a", 20230410, 1, "y2023a", "y2023a production geometry, AgML,xgeometry"},

  • { "y2023", 20231210, 0, "y2024", "y2024 first cut geometry, AgML,xgeometry"},
  • { "y2023a", 20231210, 1, "y2024a", "y2024a production geometry, AgML,xgeometry"},

Looks like this was a typo.... Should be y2024 and y2024a, yes?

-- Reply to this email directly, view it on GitHub [2], or unsubscribe [3]. You are receiving this because you modified the open/close state.Message ID: @.***>

Links:

[1] https://github.com/star-bnl/star-sw/pull/622#discussion_r1531488241 [2] https://github.com/star-bnl/star-sw/pull/622#pullrequestreview-1947911090 [3] https://github.com/notifications/unsubscribe-auth/ANL4LVFRKQBLWSRIVBOJ4NTYZEDN3AVCNFSM6AAAAAA63HNXG6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNBXHEYTCMBZGA