search

star-bnl / star-sw

Core software for STAR experiment
26 stars 63 forks source link

StiCA option defined twice in StRoot/StBFChain/BigFullChain.h #629

Open plexoos opened 6 months ago

plexoos commented 6 months ago

https://github.com/star-bnl/star-sw/blob/05ba0397d303ddec75efe26a101859d558b29475/StRoot/StBFChain/BigFullChain.h#L1717

https://github.com/star-bnl/star-sw/blob/05ba0397d303ddec75efe26a101859d558b29475/StRoot/StBFChain/BigFullChain.h#L1719-L1720

genevb commented 6 months ago

Hm. Introduced by Victor in 2016: commit 275cd0fed9fc4f444e04bf164ffd6eab6e2c7710 or https://www.star.bnl.gov/cgi-bin/protected/viewvc.cgi/cvsroot/StRoot/StBFChain/BigFullChain.h?r1=1.257&r2=1.258 with the message: "Pure Sti does not load StiCA++ libraries"

...not quite obvious :-/

genevb commented 6 months ago

There was also a tweak of the original StiCA option a few months before that by @plexoos . I'm not certain it's relevant, but adding it here in case it helps spur memories.... commit 84a7ba4e6357a74ddb9d79e740c639116251a54b

plexoos commented 6 months ago

I checked the logs, and it seems to me that the second definition is not used and can thus be removed

genevb commented 6 months ago

Thanks, Dmitri.... Second? As in the second one introduced in time into the code, or the second one in the order of the written code?

-Gene

On Nov 14, 2023, at 4:17 PM, Dmitri Smirnov @.***> wrote: I checked the logs, and it seems to me that the second definition is not used and can thus be removed

plexoos commented 6 months ago

I mean 'second' as in the order they appear in BigFullChain.h, specifically, the definition on line 1719. I don't believe options with the same name can overwrite each other or merge in any way. Perhaps, the logic is to stop scanning once an option with the desired name is found.

In the logs, it appears that only 'Sti' is being turned on by 'StiCA,' which is consistent with the first definition.