Fix job crashing for 9 time-bin FST data

star-bnl / star-sw

Core software for STAR experiment

26 stars 63 forks source link

Fix job crashing for 9 time-bin FST data #634

Closed techuan-huang closed 4 months ago

techuan-huang commented 4 months ago

Issue #631 was due to an inconsistent number of time bins used in the data and the codes. In most FST data and in the codes, we used 3 time bins, while some data used 9 time bins. Only changing a constant in StRoot/StEvent/StFstConsts.h is needed to fix this issue.

genevb commented 4 months ago

Thanks, @techuan-huang . Two notes from me:

I tried my test job with this patch and it ran to completion for me without crashing. I was careful to rebuild all the libraries that depend on this one file.
If this passes review, we should tag SL23f_1 and I will rebuild the library. SL23f has not been used for any other productions besides the preview production yet, so we should be fine with this patch.

-Gene

genevb commented 4 months ago

Are we waiting for @akioogawa 's approval, or can this be merged now?