search

star-bnl / star-sw

Core software for STAR experiment
26 stars 63 forks source link

Disable DAQ logging when compiling outside of local domains #643

Closed jml985 closed 1 month ago

jml985 commented 3 months ago

Disable DAQ logging when compiling outside of local domains

2 defines are added which should be left ignored for most offline compiles:

RTS_ENABLE_LOG RTS_LOG_DEFAULT_NET

The first will enable logging, and it will go to stderr The second enables logging to the main daq server, and can not be successful outside the local network.

plexoos commented 3 months ago

@jml985, could you please confirm that all the submitted changes are intended? You can do this by checking the "Files changed" tab at https://github.com/star-bnl/star-sw/pull/643/files. I am asking because there appear to be modifications beyond what the title and descriptions indicate. Are these changes minor enough to be disregarded?

jml985 commented 3 months ago

@plexoos Yes, there were also some changes here for the daq readers of various detectors during the summer. These could in principal be separated from this pull request if you would rather keep them independent.

plexoos commented 3 months ago

These could in principal be separated from this pull request if you would rather keep them independent.

Fine by me

genevb commented 3 months ago

@plexoos Yes, there were also some changes here for the daq readers of various detectors during the summer. These could in principal be separated from this pull request if you would rather keep them independent.

A potential reason to separate things is that, as I understand it, we're going to want to back-propagate the DAQ-logging portion of this PR into older software libraries. The FCS, iTPC, TPC23, STGC codes did not exist in old libraries, so this PR as it stands can't simply be used as is for updating old libraries.

plexoos commented 3 months ago

Yes, it's a very good point Gene. Jeff, can you prepare a patch which can be applied to older libraries?

jml985 commented 3 months ago

What is the best way to remove files from the pull request, do we drop the request and make a new one?

plexoos commented 3 months ago

Yes, considering there aren't many changes, it might be easier to create a new branch from the head of main, reintroduce only the relevant modifications, and then create a pull request using that new branch. Alternatively, you can use git revert followed by git add -e or git add -p to selectively include the relevant changes and skip the unwanted ones.

jml985 commented 3 months ago

Ok, I'll do this after my current meeting...

-Jeff

From: Dmitri Smirnov @.> Sent: Thursday, February 1, 2024 9:35 AM To: star-bnl/star-sw @.> Cc: Landgraf, Jeffery M. @.>; Mention @.> Subject: Re: [star-bnl/star-sw] Disable DAQ logging when compiling outside of local domains (PR #643)

Yes, considering there aren't many changes, it might be easier to create a new branch from the head of main, reintroduce only the relevant modifications, and then create a pull request using that new branch. Alternatively, you can use git revert followed by git add -e or git add -p to selectively include the relevant changes and skip the unwanted ones.

— Reply to this email directly, view it on GitHubhttps://github.com/star-bnl/star-sw/pull/643#issuecomment-1921478057, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKQGF6O6DFQEWS6FQJXVONTYROR3LAVCNFSM6AAAAABCTIWSKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRRGQ3TQMBVG4. You are receiving this because you were mentioned.Message ID: @.***>