search

star-bnl / star-sw

Core software for STAR experiment
26 stars 63 forks source link

Match update and event flag fix #661

Closed YannickSoehngen closed 1 month ago

YannickSoehngen commented 2 months ago

Fixed GoodEventFlag, increased granularity from counter to Get4 level, added pulser Flag (previous part of GoodEventFlag) and implementation of Single-Sided-Matches

plexoos commented 1 month ago

There was a small conflict with the main branch. I resolved it

plexoos commented 1 month ago

There are also errors from the compiler. Please address them

genevb commented 1 month ago

Are we waiting on anything here? A review from @PhilippWeidenkaff ? Or is this ready to merge?

genevb commented 1 month ago

I understand that this is the only PR on which we are critically waiting before tagging SL24a. I'll ask again: are we waiting for anything else on this PR before merging?

genevb commented 1 month ago

Nightly tests look like they went OK. @plexoos , would you please tag SL24a here and star-mcgen when you get the chance? Thanks in advance.

plexoos commented 1 month ago

Done. Branch SL24a and tag SL24a_0 should be available in the both repositories now