search

star-bnl / star-sw

Core software for STAR experiment
26 stars 63 forks source link

Jevp production #677

Closed fvidebaek closed 1 month ago

fvidebaek commented 1 month ago

Update of tpcBuilder to add new histograms most importantly tpc_rdo_bytes and itpc_rdo_bytes

fvidebaek commented 1 month ago

I am baffled and sorry I only modified 2 files in Jevp tpcBuilder.cxx and .h . I followed the recipe from Jeff. I know to little about git to change the request.

Flemming

On 2024-04-03 12:08, klendathu2k wrote:

@klendathu2k requested changes on this pull request.

2k files changed over 400 commits. Can we simplify this a bit?

-- Reply to this email directly, view it on GitHub [1], or unsubscribe [2]. You are receiving this because you authored the thread.Message ID: @.***>

Links:

[1] https://github.com/star-bnl/star-sw/pull/677#pullrequestreview-1977307995 [2] https://github.com/notifications/unsubscribe-auth/AUIALBFPQPAKZJTDN7YZGHDY3QSQHAVCNFSM6AAAAABFVSU64GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNZXGMYDOOJZGU

-- Flemming Videbaek senior scientist, emeritus videbaek @ bnl.gov Brookhaven National Lab Physics Department Bldg 510D Upton, NY 11973

phone: 631-344-4106 cell : 631-681-1596

klendathu2k commented 1 month ago

Hi Flemming,

If I had to guess, it looks like you branched off of the star-bnl:main branch, made your changes, and then submitted a pull request into the star-bnl:JevpProduction branch. That branch is... out of date... https://github.com/star-bnl/star-sw/tree/JevpProduction

Did Jeff indicate that you should merge your changes with that branch, or with main?

Jason

On 2024-04-03 12:18, fvidebaek wrote:

I am baffled and sorry I only modified 2 files in Jevp tpcBuilder.cxx

and .h . I followed the recipe from Jeff. I know to little about git to change the request.

Flemming

On 2024-04-03 12:08, klendathu2k wrote:

@klendathu2k requested changes on this pull request.

2k files changed over 400 commits. Can we simplify this a bit?

-- Reply to this email directly, view it on GitHub [1], or unsubscribe [2]. You are receiving this because you authored the thread.Message ID: @.***>

Links:

[1]

https://github.com/star-bnl/star-sw/pull/677#pullrequestreview-1977307995 [2]

https://github.com/notifications/unsubscribe-auth/AUIALBFPQPAKZJTDN7YZGHDY3QSQHAVCNFSM6AAAAABFVSU64GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNZXGMYDOOJZGU

-- Flemming Videbaek senior scientist, emeritus videbaek @ bnl.gov Brookhaven National Lab Physics Department Bldg 510D Upton, NY 11973

phone: 631-344-4106 cell : 631-681-1596

Reply to this email directly, view it on GitHub [1], or unsubscribe [2]. You are receiving this because you were mentioned.Message ID: @.***>

Links:

[1] https://github.com/star-bnl/star-sw/pull/677#issuecomment-2035036132 [2] https://github.com/notifications/unsubscribe-auth/ANL4LVG2EF7ZMONHHMQUQPLY3QTULAVCNFSM6AAAAABFVSU64GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZVGAZTMMJTGI

jml985 commented 1 month ago

It is actually only two files changed I don't know why there are so many commits

fvidebaek commented 1 month ago

Hi Jason and Jeff

it was branched off Jeff's /jml985/star-sw.git using the instructions in the README file in OnlTools/Jevp which as I understands its take the JevpProduction branch in his directory. I only committed two files and will be happy to make a proper request and kill the current Should the request be to update into Jeff's private copy and in that case how to do this?

It would be good to work together since likely there are others that will want to modify Jevp plots.

Flemming

On 2024-04-03 12:24, klendathu2k wrote:

Hi Flemming,

If I had to guess, it looks like you branched off of the star-bnl:main

branch, made your changes, and then submitted a pull request into the star-bnl:JevpProduction branch. That branch is... out of date... https://github.com/star-bnl/star-sw/tree/JevpProduction

Did Jeff indicate that you should merge your changes with that branch,

or with main?

Jason

On 2024-04-03 12:18, fvidebaek wrote:

I am baffled and sorry I only modified 2 files in Jevp tpcBuilder.cxx

and .h . I followed the recipe from Jeff. I know to little about git to change the request.

Flemming

On 2024-04-03 12:08, klendathu2k wrote:

@klendathu2k requested changes on this pull request.

2k files changed over 400 commits. Can we simplify this a bit?

-- Reply to this email directly, view it on GitHub [1], or unsubscribe [2]. You are receiving this because you authored the thread.Message ID: @.***>

Links:

[1]

https://github.com/star-bnl/star-sw/pull/677#pullrequestreview-1977307995

[2]

https://github.com/notifications/unsubscribe-auth/AUIALBFPQPAKZJTDN7YZGHDY3QSQHAVCNFSM6AAAAABFVSU64GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNZXGMYDOOJZGU

-- Flemming Videbaek senior scientist, emeritus videbaek @ bnl.gov Brookhaven National Lab Physics Department Bldg 510D Upton, NY 11973

phone: 631-344-4106 cell : 631-681-1596

Reply to this email directly, view it on GitHub [1], or unsubscribe [2]. You are receiving this because you were mentioned.Message ID: @.***>

Links:

[1] https://github.com/star-bnl/star-sw/pull/677#issuecomment-2035036132 [2]

https://github.com/notifications/unsubscribe-auth/ANL4LVG2EF7ZMONHHMQUQPLY3QTULAVCNFSM6AAAAABFVSU64GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZVGAZTMMJTGI

Reply to this email directly, view it on GitHub [1], or unsubscribe [2]. You are receiving this because you authored the thread.Message ID: @.***>

Links:

[1] https://github.com/star-bnl/star-sw/pull/677#issuecomment-2035046525 [2] https://github.com/notifications/unsubscribe-auth/AUIALBE44BTZZ7EY7SVRLQLY3QUKPAVCNFSM6AAAAABFVSU64GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZVGA2DMNJSGU

-- Flemming Videbaek senior scientist, emeritus videbaek @ bnl.gov Brookhaven National Lab Physics Department Bldg 510D Upton, NY 11973

phone: 631-344-4106 cell : 631-681-1596

jml985 commented 1 month ago

Lets simplify this, Flemming, you can remove this pull request, as they have already been incorporated with jml985/JevpProduction which is the source for the running code. I'll make a pull request with the full contents of the JevpProduction code. There are a few additional changes there but only about 10 files from star-sw/main, most of which have been already submitted as other pull requests to star-sw/main

fvidebaek commented 1 month ago

Ok I will kill this request. And tell me if I have to do anything more later.

F

On 2024-04-03 12:43, jml985 wrote:

Lets simplify this, Flemming, you can remove this pull request, as they have already been incorporated with jml985/JevpProduction which is the source for the running code. I'll make a pull request with the full contents of the JevpProduction code. There are a few additional changes there but only about 10 files from star-sw/main, most of which have been already submitted as other pull requests to star-sw/main

-- Reply to this email directly, view it on GitHub [1], or unsubscribe [2]. You are receiving this because you authored the thread.Message ID: @.***>

Links:

[1] https://github.com/star-bnl/star-sw/pull/677#issuecomment-2035088997 [2] https://github.com/notifications/unsubscribe-auth/AUIALBFRN4UPIJFAEQRZZ3LY3QWRVAVCNFSM6AAAAABFVSU64GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZVGA4DQOJZG4

-- Flemming Videbaek senior scientist, emeritus videbaek @ bnl.gov Brookhaven National Lab Physics Department Bldg 510D Upton, NY 11973

phone: 631-344-4106 cell : 631-681-1596