search

star-citizen-vr / scvr-patcher

Patcher for Star Citizen VR with VorpX written in C#
https://github.com/star-citizen-vr/scvr-patcher
18 stars 5 forks source link

Ingame resolution for Width/Height is not changed in attributes.xml when checkbox is enabled #8

Open jonathonhillnz opened 4 months ago

jonathonhillnz commented 4 months ago

Hi all,

Unsure exactly who is maintaining this project now. I noticed one of the long standing issues is the tool doesn't update the attributes.xml file with the selected resolutions even when the checkbox is checked to do so.

Capture

Looking in the code base I believe this is because the wrong non-overloaded Patch method is called from the Game class, thus changeresolution gets hardcoded to false.

https://github.com/star-citizen-vr/scvr-patcher/blob/7997bc310e0ac5f25612815cdbce3bf0c33aa54e/Classes/Game.cs#L33C1-L50C10

I have created a fork and updated the code, I am able to build and run this and can confirm it updates the resolution now. It needs more testing though.

https://github.com/star-citizen-vr/scvr-patcher/compare/csharp...jony123:fix/fix-game-resolution-changer?expand=1

mhombach commented 3 months ago

Hey and sorry for slightly highjacking this issue, but does this patcher still and really work with VorpX? My current understanding is, that the Easy Anti Cheat blocks any VorpX usage. I would love so much to try to see SC in VR but I felt it's currently impossible (also with the chance of getting banned for using injections since EAC was introduced). Wny chance someone here can enlighten me about this? ö_ö

Kaglaaz commented 3 months ago

The devs know about the anti cheat problem, so we turn it off in the settings so vorpx will run

On Sun, Aug 18, 2024, 5:14 AM Martin Hombach @.***> wrote:

Hey and sorry for slightly highjacking this issue, but does this patcher still and really work with VorpX? My current understanding is, that the Easy Anti Cheat blocks any VorpX usage. I would love so much to try to see SC in VR but I felt it's currently impossible (also with the chance of getting banned for using injections since EAC was introduced). Wny chance someone here can enlighten me about this? ö_ö

— Reply to this email directly, view it on GitHub https://github.com/star-citizen-vr/scvr-patcher/issues/8#issuecomment-2295207275, or unsubscribe https://github.com/notifications/unsubscribe-auth/BD6ENHXMW6VEZHPYORWL3HTZSBXYXAVCNFSM6AAAAABKUREGRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJVGIYDOMRXGU . You are receiving this because you were assigned.Message ID: @.***>

mhombach commented 3 months ago

[...] so we turn it off in the settings so vorpx will run @Kaglaaz Just for clarification, you turn it off in the settings FILE when your launcher/patcher is executed? Because I never saw an option for this ingame in the settings UI.

Is there some Discord for this SC VR patch btw? If not, just a quick followup question: Movement and/or controllers are not affected so I must choose and confire a gamepad or so myself? Just asking because we shall selecet our HMD so if there is any way to automatically map some basic functions like movement and interaction into the valve index controllers that would be extremely helpful. And also, do I need to configure anything else in VorpX or does your patcher does everything by itself? Sorry again for highjacking this, if there is some other way to get support for this (like a Discord), please tell me :)

Bluscream commented 3 months ago

https://discord.gg/P8GBEhjdPu