star-whale / starwhale

an MLOps/LLMOps platform
https://starwhale.ai
Apache License 2.0
208 stars 35 forks source link

refactor(controller): remove unreachable code #2951

Closed jialeicui closed 11 months ago

jialeicui commented 11 months ago

Description

Modules

Checklist

codecov[bot] commented 11 months ago

Codecov Report

Merging #2951 (27de64f) into main (dcc5c61) will increase coverage by 0.02%. The diff coverage is 79.41%.

@@             Coverage Diff              @@
##               main    #2951      +/-   ##
============================================
+ Coverage     83.04%   83.07%   +0.02%     
+ Complexity     3107     3099       -8     
============================================
  Files           558      555       -3     
  Lines         30395    30093     -302     
  Branches       1818     1755      -63     
============================================
- Hits          25242    24999     -243     
+ Misses         4347     4292      -55     
+ Partials        806      802       -4     
Flag Coverage Δ
console ?
controller 74.04% <72.00%> (-0.09%) :arrow_down:
standalone 92.15% <100.00%> (-0.02%) :arrow_down:
unittests 92.15% <100.00%> (+0.26%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/starwhale/base/client/models/models.py 100.00% <100.00%> (ø)
...a/ai/starwhale/mlops/api/EvaluationController.java 94.44% <ø> (-1.12%) :arrow_down:
...ain/java/ai/starwhale/mlops/api/JobController.java 82.60% <ø> (ø)
...ale/mlops/domain/evaluation/EvaluationService.java 67.85% <100.00%> (-7.91%) :arrow_down:
...whale/mlops/domain/job/converter/JobConverter.java 74.74% <ø> (-0.51%) :arrow_down:
...e/mlops/domain/job/converter/UserJobConverter.java 83.46% <100.00%> (+0.26%) :arrow_up:
.../starwhale/mlops/domain/ft/FineTuneAppService.java 85.10% <87.50%> (-0.77%) :arrow_down:
...in/java/ai/starwhale/mlops/common/IdConverter.java 88.23% <66.66%> (-11.77%) :arrow_down:
...tarwhale/mlops/api/protocol/job/JobTemplateVo.java 0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes