star-whale / starwhale

an MLOps/LLMOps platform
https://starwhale.ai
Apache License 2.0
208 stars 35 forks source link

fix(controller): run log save doesn't break status report #2994

Closed anda-ren closed 11 months ago

anda-ren commented 11 months ago

Description

  1. run log save doesn't break status report
  2. add retry for run log saving

Modules

Checklist

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6b29a60) 82.45% compared to head (6867ba4) 73.29%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2994 +/- ## ============================================ - Coverage 82.45% 73.29% -9.17% - Complexity 3110 3118 +8 ============================================ Files 563 436 -127 Lines 30336 15181 -15155 Branches 1825 1764 -61 ============================================ - Hits 25015 11127 -13888 + Misses 4516 3247 -1269 - Partials 805 807 +2 ``` | [Flag](https://app.codecov.io/gh/star-whale/starwhale/pull/2994/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | Coverage Δ | | |---|---|---| | [console](https://app.codecov.io/gh/star-whale/starwhale/pull/2994/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `?` | | | [controller](https://app.codecov.io/gh/star-whale/starwhale/pull/2994/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `73.29% <100.00%> (+0.03%)` | :arrow_up: | | [standalone](https://app.codecov.io/gh/star-whale/starwhale/pull/2994/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `?` | | | [unittests](https://app.codecov.io/gh/star-whale/starwhale/pull/2994/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.