star-whale / starwhale

an MLOps/LLMOps platform
https://starwhale.ai
Apache License 2.0
208 stars 35 forks source link

enhance(client): question answering infer type support multiple args #2997

Closed jialeicui closed 11 months ago

jialeicui commented 11 months ago

Description

Modules

Checklist

codecov[bot] commented 11 months ago

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (4d2db61) 82.51% compared to head (4d22c06) 91.95%. Report is 12 commits behind head on main.

Files Patch % Lines
client/starwhale/api/_impl/service/types/types.py 64.10% 14 Missing :warning:
client/starwhale/api/_impl/service/types/llm.py 85.29% 5 Missing :warning:
client/starwhale/api/_impl/service/service.py 88.23% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2997 +/- ## ============================================ + Coverage 82.51% 91.95% +9.44% ============================================ Files 563 126 -437 Lines 30353 15033 -15320 Branches 1826 0 -1826 ============================================ - Hits 25045 13824 -11221 + Misses 4503 1209 -3294 + Partials 805 0 -805 ``` | [Flag](https://app.codecov.io/gh/star-whale/starwhale/pull/2997/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | Coverage Δ | | |---|---|---| | [console](https://app.codecov.io/gh/star-whale/starwhale/pull/2997/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `?` | | | [controller](https://app.codecov.io/gh/star-whale/starwhale/pull/2997/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `?` | | | [standalone](https://app.codecov.io/gh/star-whale/starwhale/pull/2997/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `91.95% <77.17%> (-0.09%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/star-whale/starwhale/pull/2997/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `91.95% <77.17%> (+0.19%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tianweidut commented 11 months ago

Others LGTM