search

star-whale / starwhale

an MLOps/LLMOps platform
https://starwhale.ai
Apache License 2.0
208 stars 35 forks source link

fix(controller): add resource validation for ftspace #3017

Closed goldenxinxing closed 11 months ago

goldenxinxing commented 11 months ago

Description

  1. check whether the space belongs to project.
  2. add spaceId constraint for ft info.

Modules

Checklist

codecov[bot] commented 11 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (98823b4) 91.83% compared to head (8497d7b) 73.70%.

Files Patch % Lines
...ai/starwhale/mlops/domain/ft/FineTuneSpaceDao.java 50.00% 3 Missing :warning:
...ava/ai/starwhale/mlops/api/FineTuneController.java 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3017 +/- ## ============================================= - Coverage 91.83% 73.70% -18.14% - Complexity 0 3142 +3142 ============================================= Files 126 429 +303 Lines 15036 15258 +222 Branches 0 1773 +1773 ============================================= - Hits 13809 11246 -2563 - Misses 1227 3204 +1977 - Partials 0 808 +808 ``` | [Flag](https://app.codecov.io/gh/star-whale/starwhale/pull/3017/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | Coverage Δ | | |---|---|---| | [controller](https://app.codecov.io/gh/star-whale/starwhale/pull/3017/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `73.70% <66.66%> (?)` | | | [standalone](https://app.codecov.io/gh/star-whale/starwhale/pull/3017/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `?` | | | [unittests](https://app.codecov.io/gh/star-whale/starwhale/pull/3017/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.