search

star-whale / starwhale

an MLOps/LLMOps platform
https://starwhale.ai
Apache License 2.0
208 stars 35 forks source link

fix(controller): add validation for eval import/export #3018

Closed goldenxinxing closed 11 months ago

goldenxinxing commented 11 months ago

Description

  1. add validation for import and export
  2. tune request body

Modules

Checklist

codecov[bot] commented 11 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (cdae936) 91.40% compared to head (a70a019) 82.82%. Report is 7 commits behind head on main.

Files Patch % Lines
...ava/ai/starwhale/mlops/api/FineTuneController.java 0.00% 2 Missing :warning:
.../starwhale/mlops/domain/ft/FineTuneAppService.java 92.85% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3018 +/- ## ============================================ - Coverage 91.40% 82.82% -8.58% - Complexity 0 3158 +3158 ============================================ Files 129 555 +426 Lines 15032 30421 +15389 Branches 61 1777 +1716 ============================================ + Hits 13740 25197 +11457 - Misses 1290 4414 +3124 - Partials 2 810 +808 ``` | [Flag](https://app.codecov.io/gh/star-whale/starwhale/pull/3018/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | Coverage Δ | | |---|---|---| | [console](https://app.codecov.io/gh/star-whale/starwhale/pull/3018/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `?` | | | [controller](https://app.codecov.io/gh/star-whale/starwhale/pull/3018/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `73.92% <86.66%> (?)` | | | [standalone](https://app.codecov.io/gh/star-whale/starwhale/pull/3018/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `91.91% <100.00%> (+0.23%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/star-whale/starwhale/pull/3018/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `91.91% <100.00%> (+0.51%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.