search

star-whale / starwhale

an MLOps/LLMOps platform
https://starwhale.ai
Apache License 2.0
208 stars 35 forks source link

feat(controller): add domain names for object storage #3029

Closed anda-ren closed 10 months ago

anda-ren commented 11 months ago

Description

recognize regex pattern for the object store domain in the header

client part: https://github.com/star-whale/starwhale/pull/3048

Test cases

image

Modules

Checklist

codecov[bot] commented 11 months ago

Codecov Report

Attention: 139 lines in your changes are missing coverage. Please review.

Comparison is base (73d35ef) 82.94% compared to head (31e9c97) 73.53%. Report is 1 commits behind head on main.

Files Patch % Lines
...mlops/storage/ksyun/StorageAccessServiceKsyun.java 0.00% 43 Missing :warning:
...ops/storage/qcloud/StorageAccessServiceQcloud.java 0.00% 33 Missing :warning:
...e/mlops/storage/baidu/StorageAccessServiceBos.java 0.00% 23 Missing :warning:
...ops/storage/aliyun/StorageAccessServiceAliyun.java 29.41% 11 Missing and 1 partial :warning:
...torage/domain/DomainAwareStorageAccessService.java 78.04% 6 Missing and 3 partials :warning:
...mlops/storage/minio/StorageAccessServiceMinio.java 72.72% 6 Missing :warning:
...whale/mlops/storage/s3/StorageAccessServiceS3.java 83.78% 6 Missing :warning:
...starwhale/mlops/domain/blob/CachedBlobService.java 0.00% 3 Missing :warning:
...ion/security/ObjectStoreDomainDetectionFilter.java 89.47% 2 Missing :warning:
.../starwhale/mlops/storage/StorageAccessService.java 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3029 +/- ## ============================================ - Coverage 82.94% 73.53% -9.41% - Complexity 3168 3205 +37 ============================================ Files 568 433 -135 Lines 31490 15638 -15852 Branches 1850 1809 -41 ============================================ - Hits 26119 11500 -14619 + Misses 4552 3316 -1236 - Partials 819 822 +3 ``` | [Flag](https://app.codecov.io/gh/star-whale/starwhale/pull/3029/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | Coverage Δ | | |---|---|---| | [console](https://app.codecov.io/gh/star-whale/starwhale/pull/3029/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `?` | | | [controller](https://app.codecov.io/gh/star-whale/starwhale/pull/3029/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `73.53% <43.26%> (-0.39%)` | :arrow_down: | | [standalone](https://app.codecov.io/gh/star-whale/starwhale/pull/3029/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `?` | | | [unittests](https://app.codecov.io/gh/star-whale/starwhale/pull/3029/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.