search

star-whale / starwhale

an MLOps/LLMOps platform
https://starwhale.ai
Apache License 2.0
208 stars 35 forks source link

refactor(controller): remove column schemas dependency #3057

Closed jialeicui closed 10 months ago

jialeicui commented 10 months ago

Description

columnSchemaMap in the RecordList is the latest version of the data but the query or scan supports the old version of the data, so the columnSchemaMap is meaningless except for names we remove the column schema info from the result and other getting function calls except for parquet dump and load

Modules

Checklist

codecov[bot] commented 10 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (4ddef36) 82.90% compared to head (365af49) 73.89%. Report is 2 commits behind head on main.

:exclamation: Current head 365af49 differs from pull request most recent head 245ac6f. Consider uploading reports for the commit 245ac6f to get more accurate results

Files Patch % Lines
...arwhale/mlops/datastore/impl/WalRecordDecoder.java 77.77% 0 Missing and 4 partials :warning:
...java/ai/starwhale/mlops/datastore/TableSchema.java 66.66% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3057 +/- ## ============================================ - Coverage 82.90% 73.89% -9.01% + Complexity 3167 3160 -7 ============================================ Files 569 431 -138 Lines 31541 15423 -16118 Branches 1850 1783 -67 ============================================ - Hits 26148 11397 -14751 + Misses 4574 3209 -1365 + Partials 819 817 -2 ``` | [Flag](https://app.codecov.io/gh/star-whale/starwhale/pull/3057/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | Coverage Δ | | |---|---|---| | [console](https://app.codecov.io/gh/star-whale/starwhale/pull/3057/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `?` | | | [controller](https://app.codecov.io/gh/star-whale/starwhale/pull/3057/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `73.89% <82.75%> (-0.03%)` | :arrow_down: | | [standalone](https://app.codecov.io/gh/star-whale/starwhale/pull/3057/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `?` | | | [unittests](https://app.codecov.io/gh/star-whale/starwhale/pull/3057/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.