star-whale / starwhale

an MLOps/LLMOps platform
https://starwhale.ai
Apache License 2.0
208 stars 35 forks source link

refactor(controller): add job create function in EvaluationService #3066

Closed anda-ren closed 10 months ago

anda-ren commented 10 months ago

Description

add job create function in EvaluationService and use it explicitly in JobCreateController so that the later refactor could be more clear

Modules

Checklist

codecov[bot] commented 10 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f4c3916) 82.92% compared to head (f2ae3d1) 73.50%. Report is 8 commits behind head on main.

Files Patch % Lines
...ain/java/ai/starwhale/mlops/api/JobController.java 66.66% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3066 +/- ## ============================================ - Coverage 82.92% 73.50% -9.43% - Complexity 3167 3204 +37 ============================================ Files 569 433 -136 Lines 31541 15649 -15892 Branches 1850 1812 -38 ============================================ - Hits 26156 11503 -14653 + Misses 4565 3323 -1242 - Partials 820 823 +3 ``` | [Flag](https://app.codecov.io/gh/star-whale/starwhale/pull/3066/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | Coverage Δ | | |---|---|---| | [console](https://app.codecov.io/gh/star-whale/starwhale/pull/3066/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `?` | | | [controller](https://app.codecov.io/gh/star-whale/starwhale/pull/3066/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `73.50% <83.33%> (-0.41%)` | :arrow_down: | | [standalone](https://app.codecov.io/gh/star-whale/starwhale/pull/3066/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `?` | | | [unittests](https://app.codecov.io/gh/star-whale/starwhale/pull/3066/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.