star-whale / starwhale

an MLOps/LLMOps platform
https://starwhale.ai
Apache License 2.0
208 stars 35 forks source link

feat: add custom args #3117

Closed goldenxinxing closed 9 months ago

goldenxinxing commented 9 months ago

Description

  1. write arguments spec to job.yaml
  2. support parse arguments in server side
  3. output the failed log in githua action

Modules

Checklist

codecov[bot] commented 9 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (cd671cb) 91.60% compared to head (a48d6c2) 82.95%.

Files Patch % Lines
.../impl/SwCliModelHandlerContainerSpecification.java 86.66% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3117 +/- ## ============================================ - Coverage 91.60% 82.95% -8.66% - Complexity 0 3193 +3193 ============================================ Files 142 572 +430 Lines 16442 31910 +15468 Branches 61 1812 +1751 ============================================ + Hits 15062 26471 +11409 - Misses 1378 4612 +3234 - Partials 2 827 +825 ``` | [Flag](https://app.codecov.io/gh/star-whale/starwhale/pull/3117/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | Coverage Δ | | |---|---|---| | [console](https://app.codecov.io/gh/star-whale/starwhale/pull/3117/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `?` | | | [controller](https://app.codecov.io/gh/star-whale/starwhale/pull/3117/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `73.45% <86.66%> (?)` | | | [standalone](https://app.codecov.io/gh/star-whale/starwhale/pull/3117/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `92.10% <100.00%> (+0.24%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/star-whale/starwhale/pull/3117/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `92.10% <100.00%> (+0.50%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tianweidut commented 9 months ago

Others LGTM