search

star-whale / starwhale

an MLOps/LLMOps platform
https://starwhale.ai
Apache License 2.0
208 stars 35 forks source link

fix(controller): support multiple value #3131

Closed goldenxinxing closed 9 months ago

goldenxinxing commented 9 months ago

Description

when the argument is multiple, like this: image

the expect action is: image

Modules

Checklist

codecov[bot] commented 9 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (55955c1) 82.94% compared to head (37dd2fc) 82.94%.

Files Patch % Lines
.../impl/SwCliModelHandlerContainerSpecification.java 87.50% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3131 +/- ## ============================================ - Coverage 82.94% 82.94% -0.01% - Complexity 3193 3194 +1 ============================================ Files 575 575 Lines 32107 32112 +5 Branches 1873 1875 +2 ============================================ + Hits 26631 26634 +3 - Misses 4646 4647 +1 - Partials 830 831 +1 ``` | [Flag](https://app.codecov.io/gh/star-whale/starwhale/pull/3131/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | Coverage Δ | | |---|---|---| | [console](https://app.codecov.io/gh/star-whale/starwhale/pull/3131/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `72.09% <ø> (ø)` | | | [controller](https://app.codecov.io/gh/star-whale/starwhale/pull/3131/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `73.44% <87.50%> (-0.01%)` | :arrow_down: | | [standalone](https://app.codecov.io/gh/star-whale/starwhale/pull/3131/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `92.24% <100.00%> (ø)` | | | [unittests](https://app.codecov.io/gh/star-whale/starwhale/pull/3131/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale) | `91.98% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=star-whale#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.