Closed staratlasjim closed 2 years ago
Working through a bug where the GmEventService doesn't correctly handle the onEvent callback handler being null.
onEvent
If the health check service determines that the GmEventService needs to be restarted, the onEvent handler would be set to null.
GmOrderBookService.ts: This fixes both the condition that inadvertently set the GmEventService::onEvent to null (line 116).
Added logic to handle not having an onEvent handler in the GmEventService.
some formatting changes due to prettier/eslint configs in my ide.
Task linked: CU-2nvdmn8 [Bug] Orders not loading in category orders view
bravetarget
commented
2 years ago bravetarget
commented
2 years ago
Changes
Working through a bug where the GmEventService doesn't correctly handle the
onEventcallback handler being null.If the health check service determines that the GmEventService needs to be restarted, the
onEventhandler would be set to null.GmOrderBookService.ts: This fixes both the condition that inadvertently set the GmEventService::onEvent to null (line 116).
Added logic to handle not having an
onEventhandler in the GmEventService.some formatting changes due to prettier/eslint configs in my ide.
Checklist