Fix CI, Fix Build - Githubissues

NullVoxPopuli commented 10 months ago

The main problem: pnpm build fails.

Solution:

have turbo do everything. this is literally 2 lines of package.json changes (but applied to each package.json)

The whole PR:

use correct ci.yml (to read our tooling versions from package.json)
upgrade esyes (so that errors correctly fail the invocation)
add turbo.json config
fix the top level build and lint:fix scripts
run this script:

script-that-adds-build-and-prepack
```js import { project, packageJson } from "ember-apply"; for (let workspace of await project.getWorkspaces()) { let manifest = await packageJson.read(workspace); if (manifest.private || !manifest.name) continue; let hasRollup = manifest?.devDependencies?.rollup || manifest?.dependencies?.rollup; if (!hasRollup) { continue; } try { await workOn(workspace); } catch (e) { console.error(workspace); console.error(e); } } async function workOn(workspace) { await packageJson.modify((json) => { json.scripts ||= {}; json.scripts.build = "rollup -c"; json.scripts.prepack = "pnpm build"; }, workspace); } ```

stackblitz[bot] commented 10 months ago

Run & review this pull request in StackBlitz Codeflow.

socket-security[bot] commented 10 months ago

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
eslint-config-prettier	9.1.0	None	`+0`	20.8 kB	lydell
esyes	1.0.1...1.0.2	network	`+1/-1`	426 kB
vitest	1.0.0-beta.4...1.1.0	None	`+3/-0`	1.39 MB	oreanno

starbeamjs / starbeam