search

starburstdata / dbt-trino

The Trino (https://trino.io/) adapter plugin for dbt (https://getdbt.com)
Apache License 2.0
196 stars 53 forks source link

`ROLE` as standalone field? #246

Open dataders opened 1 year ago

dataders commented 1 year ago

Describe the feature

It was not immediately appararent from the UI or the reference documentation that it is convention in Starburst Galaxy to postfix the intended role to the user like user@domain.com/ROLE is this always the case? what happens if you don't include it? is there a default? should it be a standalone field?

I know it's tricky to support OSS Trino, SB Enterprise and Galaxy and all possible authentication, but I think there's still opportunity for improvement

Describe alternatives you've considered

Clarify the documentation?

Who will benefit?

No response

Are you willing to submit PR?

leniartek commented 1 year ago

Hi @dataders user@domain.com/ROLE is unique notation for Starburst Galaxy. Starburst Enterprise and OSS Trino only support ROLES field.

We will introduce a new ROLE field in python client and dbt adapter to standardise the access control across all platforms. https://github.com/trinodb/trino-python-client/pull/341