starburstdata / metabase-driver

Starburst Metabase driver
Apache License 2.0
65 stars 10 forks source link

hope add x.47 version support #106

Closed ylq5126 closed 1 year ago

ylq5126 commented 1 year ago

metabase x.47 timestamp field not support

MohsenIT commented 1 year ago

We cannot filter of aggregate on any datetime field (on Trino Catalogs only) in the last version using Metabase UI (Question), while native query is OK yet. The error: Wrong number of args (1) passed to: metabase.query-processor.timezone/report-timezone-id-if-supported

marcpearson commented 1 year ago

I receive the same error with metabase 0.47.X. when filtering any date/timestamp field. Maybe it as something to do with this https://www.metabase.com/docs/latest/developers-guide/driver-changelog

My Trino installlation have multiples types of catalog SQLServer and MySQL. But the query doesn't pass metabase because the Trino Web UI don't show any running query.

I receive the same error message when in the metabase query wizard (after added a date filter...) i click the button to view the raw SQL query... the popup contain the error : wrong number of args (1) ....

Metabase is configure with America/New_York for timezone reporting

lpoulain commented 1 year ago

I was finally able to reproduce this issue. Let me look at this.

lpoulain commented 1 year ago

@marcpearson the deprecated API mentioned in the link you gave have actually nothing to do with this error. For some reason the Metabase report-timezone-id-if-supported API has changed and I cannot find any documentation about it.

It's still useful information as some API will be removed with Metabase 0.50.0.

MohsenIT commented 1 year ago

I try to show when bug appears.

1. filter variable on date column

the native query run correctly: image

but when change filter to UI variable: Screenshot from 2023-09-20 08-38-00

MohsenIT commented 1 year ago

2. filter on a column

  1. load a table image
  2. filter on date column using UI image
  3. error: image
MohsenIT commented 1 year ago

@marcpearson the deprecated API mentioned in the link you gave have actually nothing to do with this error. For some reason the Metabase report-timezone-id-if-supported API has changed and I cannot find any documentation about it.

It's still useful information as some API will be removed with Metabase 0.50.0.

Filtering on date-time column is a very useful use-case and releasing 0.50 version is not so soon. Any other solution?

lpoulain commented 1 year ago

@MohsenIT Metabase 0.50 has nothing to do with the current error. I am working on a fix for the datetime filter.

marcpearson commented 1 year ago

Any development for the fix ...the pull request seem to be stalled with failing tests

lpoulain commented 1 year ago

It turns out that the upgrade to 0.47.x is more complex than expected, as more than one API changed with that version. Working to understand why are the tests failing now.

MohsenIT commented 1 year ago

@lpoulain Thanks for your follow up. Is there any good news about resolving this problem? We have daily reporting this issue from our users (they cannot filter date from metabase UI). At first, we try to revert Metabase x.47 update, but reverting caused several other issues. The only way we have now is to solve this metabase-driver issue.

lpoulain commented 1 year ago

@MohsenIT I believe I was able to fix the issue. The PR is in its review stage right now.

lpoulain commented 1 year ago

The Metabase Driver 4.0.0 (which contains the fix for this issue) has been released.

marcpearson commented 1 year ago

Thank you very much. Very appreciate

lpoulain commented 1 year ago

Pas de problème ;-)

MohsenIT commented 1 year ago

I wanted to express my gratitude for your support . Thanks a lot.