search

starburstdata / metabase-driver

Starburst Metabase driver
Apache License 2.0
60 stars 11 forks source link

Add query remarks #114

Closed paoliniluis closed 8 months ago

paoliniluis commented 8 months ago

Query remarks are a useful option to get information about the context of the query. It is defined in https://github.com/metabase/metabase/blob/dc676e1e649249c4ddb2ff9ee3752682596b0f23/src/metabase/query_processor/util.clj#L54 and then overriden by the driver, e.g. Redshift https://github.com/metabase/metabase/blob/dc676e1e649249c4ddb2ff9ee3752682596b0f23/modules/drivers/redshift/src/metabase/driver/redshift.clj#L312

lpoulain commented 8 months ago

Is there any particular information you believe should be passed? The extra information passed by Redshift doesn't seem to be relevant for us.

paoliniluis commented 8 months ago

I was thinking about the same information as redshift (dashboard, user, chart and filter being used). Why aren’t the redshift ones relevant?

lpoulain commented 8 months ago

If I use the same method than Redshift the values are mostly null. Are those supposed to be filled in when performing particular operations?

lpoulain commented 8 months ago

Never mind, I was able to generate some chart ID and dashboard ID.