starburstdata / metabase-driver

Starburst Metabase driver
Apache License 2.0
60 stars 11 forks source link

Support JDBC explicitPrepare flag #117

Closed lpoulain closed 7 months ago

lpoulain commented 8 months ago

Now that JDBC has a new explicitPrepare flag (Trino 431+) to use EXECUTE IMMEDIATE for prepared statements (Trino 418+), allow a new database option to use this (it is set on by default). This is achieved by a few changes:

As far as testing goes, we are running the whole Metabase test suite against both options (hence a modification in Makefile). The downside is that we are running many tests which are independent of the explicitPrepare option.

New flag when defining a connection (including error message):

Screenshot 2023-10-26 at 3 42 22 PM

Error message when a query fails with Expecting: 'USING':

Screenshot 2023-10-26 at 11 58 56 AM

lpoulain commented 7 months ago

@andrewdibiasio6 changelog updated