search

starburstgem / starburst

In-app announcements to users in your Rails app
MIT License
257 stars 29 forks source link

Adds support for current Rails versions (4.2+) #17

Closed erichmachado closed 5 years ago

erichmachado commented 5 years ago

This PR aims to update Starburst to work with the latest versions of Rails. Due to changes in some of the dependencies to make it work with those new versions, I also had to drop support to Rails versions that are not being actively maintained.

The new versions supported are 4.2, 5.0, 5.1, and 5.2. Support for versions below those has been dropped. Specs, dependencies and the implementation were updated accordingly.

The only thing that should be done after this is merged and before releasing the new gem is to bump up the version, I've left that to the maintainers intentionally.

This should also fix https://github.com/csm123/starburst/issues/16.

erichmachado commented 5 years ago

Hi @csm123, have you had the chance to look into this? I can make changes if you like. We are looking forward to having a version of the gem that supports the newer versions of Rails.

csm123 commented 5 years ago

I apologize for my delay here. This looks great. Could you fix the tabs vs spaces notes that Hound left? Then I can bump the version and merge this in.

erichmachado commented 5 years ago

Hi @csm123, thank you for your reply. Sure, I can fix Hound's issues, no problem.

I didn't want to do it at first because to fix those it will require significantly more line changes in this PR, since to have those lines properly indented I'll have to touch several lines surrounding them as well. If you're OK with that, then I can do it, no problem.

csm123 commented 5 years ago

I agree. Merging and will get a new gem version out this week. Thank you!

pavanjoshi914 commented 3 years ago

@csm123 I am still getting sanitize errors are this changes in work? If yes , suggest me the way to integrate it with rails 4.2+ and remove santize errors

erichmachado commented 3 years ago

Hi @pavanjoshi914, can you please provide more context about the errors you're experiencing? Maybe you could copy and paste the messages here so we can better support you.

I would also advice you to try out installing the gem through the latest version of the master branch and let us know if it solves the problem for you.